Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755880AbcDBB6k (ORCPT ); Fri, 1 Apr 2016 21:58:40 -0400 Received: from mail-pa0-f65.google.com ([209.85.220.65]:36411 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755493AbcDBB6h (ORCPT ); Fri, 1 Apr 2016 21:58:37 -0400 Date: Sat, 2 Apr 2016 04:58:30 +0300 From: Leon Romanovsky To: Lijun Ou Cc: dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, davem@davemloft.net, jeffrey.t.kirsher@intel.com, jiri@mellanox.com, ogerlitz@mellanox.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, gongyangming@huawei.com, xiaokun@huawei.com, tangchaofei@huawei.com, haifeng.wei@huawei.com, yisen.zhuang@huawei.com, yankejian@huawei.com, lisheng011@huawei.com, charles.chenxin@huawei.com, linuxarm@huawei.com Subject: Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support Message-ID: <20160402015830.GD8565@leon.nu> Reply-To: leon@leon.nu Mail-Followup-To: Lijun Ou , dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, davem@davemloft.net, jeffrey.t.kirsher@intel.com, jiri@mellanox.com, ogerlitz@mellanox.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, gongyangming@huawei.com, xiaokun@huawei.com, tangchaofei@huawei.com, haifeng.wei@huawei.com, yisen.zhuang@huawei.com, yankejian@huawei.com, lisheng011@huawei.com, charles.chenxin@huawei.com, linuxarm@huawei.com References: <1459502492-19891-1-git-send-email-oulijun@huawei.com> <1459502492-19891-3-git-send-email-oulijun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459502492-19891-3-git-send-email-oulijun@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2643 Lines: 53 On Fri, Apr 01, 2016 at 05:21:31PM +0800, Lijun Ou wrote: > The driver for HiSilicon RoCE is a platform driver. > The driver will support multiple versions of hardware. Currently only "v1" > for hip06 SoC is supported. > The driver includes two parts: common driver and hardware-specific > operations. hns_roce_v1_hw.c and hns_roce_v1_hw.h are files for > hardware-specific operations only for v1 engine, and other files(.c and .h) > for common algorithm and common hardware operations. > > Signed-off-by: Lijun Ou > Signed-off-by: Wei Hu(Xavier) > Signed-off-by: Znlong > --- > MAINTAINERS | 8 + > drivers/infiniband/Kconfig | 1 + > drivers/infiniband/hw/Makefile | 1 + > drivers/infiniband/hw/hisilicon/hns/Kconfig | 10 + > drivers/infiniband/hw/hisilicon/hns/Makefile | 9 + > drivers/infiniband/hw/hisilicon/hns/hns_roce_ah.c | 110 + We are not adding name of company (hisilicon) for infiniband HW drivers drivers/infiniband/hw/hisilicon/hns/hns_roce_ah.c ---> drivers/infiniband/hw/hns/hns_roce_ah.c > .../infiniband/hw/hisilicon/hns/hns_roce_alloc.c | 239 ++ ^^^^^^ Please fix you paths. > drivers/infiniband/hw/hisilicon/hns/hns_roce_cmd.c | 338 +++ > drivers/infiniband/hw/hisilicon/hns/hns_roce_cmd.h | 80 + > .../infiniband/hw/hisilicon/hns/hns_roce_common.h | 308 +++ > drivers/infiniband/hw/hisilicon/hns/hns_roce_cq.c | 436 +++ > .../infiniband/hw/hisilicon/hns/hns_roce_device.h | 794 ++++++ > drivers/infiniband/hw/hisilicon/hns/hns_roce_eq.c | 758 ++++++ > drivers/infiniband/hw/hisilicon/hns/hns_roce_eq.h | 132 + > drivers/infiniband/hw/hisilicon/hns/hns_roce_icm.c | 578 ++++ > drivers/infiniband/hw/hisilicon/hns/hns_roce_icm.h | 112 + > .../infiniband/hw/hisilicon/hns/hns_roce_main.c | 1097 ++++++++ > drivers/infiniband/hw/hisilicon/hns/hns_roce_mr.c | 605 +++++ > drivers/infiniband/hw/hisilicon/hns/hns_roce_pd.c | 124 + > drivers/infiniband/hw/hisilicon/hns/hns_roce_qp.c | 841 ++++++ > .../infiniband/hw/hisilicon/hns/hns_roce_user.h | 31 + > .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c | 2832 ++++++++++++++++++++ > .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.h | 985 +++++++ ^^^^^^ Do you support v1 of RoCE or v1 of your HW? > 23 files changed, 10429 insertions(+) Please appreciate the effort needed to review such large patch and invest time and effort to divide this to number of small easy review patches.