Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752446AbcDBDQ0 (ORCPT ); Fri, 1 Apr 2016 23:16:26 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:34640 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751183AbcDBDQY (ORCPT ); Fri, 1 Apr 2016 23:16:24 -0400 Date: Fri, 1 Apr 2016 21:16:15 -0600 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Peter Huewe , Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH] tpm: remove redundant code from self-test functions Message-ID: <20160402031615.GA28449@obsidianresearch.com> References: <1459344045-21602-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20160331054623.GB20504@obsidianresearch.com> <20160331063756.GA6393@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160331063756.GA6393@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 733 Lines: 18 On Thu, Mar 31, 2016 at 09:37:56AM +0300, Jarkko Sakkinen wrote: > On Wed, Mar 30, 2016 at 11:46:23PM -0600, Jason Gunthorpe wrote: > > On Wed, Mar 30, 2016 at 04:20:45PM +0300, Jarkko Sakkinen wrote: > > > > > - rc = be32_to_cpu(cmd.header.out.return_code); > > > if (rc == TPM_ERR_DISABLED || rc == TPM_ERR_DEACTIVATED) { > > > > This line is the entire reason it is open coded, I see it being > > removed, but I don't see how the functionality is maintained? > > When tpm_trance_cmd() returns a positive number it is the TPM error code > that it returns. tpm_pcr_read() does pass through whatever > tpm_trace_cmd() returns so the above condition should still work as > expected. Okay, everything looks fine to me Jason