Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751668AbcDBO1U (ORCPT ); Sat, 2 Apr 2016 10:27:20 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:33167 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbcDBO1S (ORCPT ); Sat, 2 Apr 2016 10:27:18 -0400 X-ME-Helo: belgarion.home X-ME-Date: Sat, 02 Apr 2016 16:27:15 +0200 X-ME-IP: 109.220.179.185 From: Robert Jarzmik To: Guennadi Liakhovetski , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Robert Jarzmik Subject: [PATCH RFC v2 0/2] pxa_camera transition to v4l2 standalone device Date: Sat, 2 Apr 2016 16:26:51 +0200 Message-Id: <1459607213-15774-1-git-send-email-robert.jarzmik@free.fr> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4793 Lines: 137 Hi Hans and Guennadi, This is the second opus of this RFC. The goal is still to see how close our ports are to see if there are things we could either reuse of change. >From RFCv1, the main change is cleaning up in function names and functions grouping, and fixes to make v4l2-compliance happy while live tests still show no regression. For the next steps, I'll have to : - split the second patch, which will be a headache task, into : - first functions grouping and renaming => this to ensure the "internal functions" are almost untouched - the the port itself I'm leaving soc_mediabus for now, that's another task. I'm not seeing a big review traction, especially on the vb2 conversion, so I'll leave this patchset in RFC form until vb2 patch is reviewed and merged, and then will come back to this work. For information, here is the result of v4l2-compliance -s. Driver Info: Driver name : pxa27x-camera Card type : PXA_Camera Bus info : platform:pxa-camera Driver version: 4.6.0 Capabilities : 0x84200001 Video Capture Streaming Extended Pix Format Device Capabilities Device Caps : 0x04200001 Video Capture Streaming Extended Pix Format Compliance test for device /dev/video0 (not using libv4l2): Required ioctls: test VIDIOC_QUERYCAP: OK Allow for multiple opens: test second video open: OK test VIDIOC_QUERYCAP: OK test VIDIOC_G/S_PRIORITY: OK Debug ioctls: test VIDIOC_DBG_G/S_REGISTER: OK test VIDIOC_LOG_STATUS: OK (Not Supported) Input ioctls: test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported) test VIDIOC_G/S/ENUMINPUT: OK test VIDIOC_G/S_AUDIO: OK (Not Supported) Inputs: 1 Audio Inputs: 0 Tuners: 0 Output ioctls: test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported) Outputs: 0 Audio Outputs: 0 Modulators: 0 Input/Output configuration ioctls: test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported) Test input 0: Control ioctls: test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK (Not Supported) test VIDIOC_QUERYCTRL: OK (Not Supported) test VIDIOC_G/S_CTRL: OK (Not Supported) test VIDIOC_G/S/TRY_EXT_CTRLS: OK (Not Supported) test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0 Format ioctls: test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK warn: v4l2-test-formats.cpp(713): TRY_FMT cannot handle an invalid pixelformat. warn: v4l2-test-formats.cpp(714): This may or may not be a problem. For more information see: warn: v4l2-test-formats.cpp(715): http://www.mail-archive.com/linux-media@vger.kernel.org/msg56550.html test VIDIOC_TRY_FMT: OK warn: v4l2-test-formats.cpp(933): S_FMT cannot handle an invalid pixelformat. warn: v4l2-test-formats.cpp(934): This may or may not be a problem. For more information see: warn: v4l2-test-formats.cpp(935): http://www.mail-archive.com/linux-media@vger.kernel.org/msg56550.html test VIDIOC_S_FMT: OK test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported) test Composing: OK (Not Supported) test Scaling: OK Codec ioctls: test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls: test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK Test input 0: Streaming ioctls: test read/write: OK (Not Supported) test MMAP: OK test USERPTR: OK test DMABUF: Cannot test, specify --expbuf-device Total: 45, Succeeded: 45, Failed: 0, Warnings: 6 Robert Jarzmik (2): media: platform: transfer format translations to soc_mediabus media: platform: pxa_camera: make a standalone v4l2 device drivers/media/platform/soc_camera/pxa_camera.c | 1086 ++++++++++++---------- drivers/media/platform/soc_camera/soc_camera.c | 7 +- drivers/media/platform/soc_camera/soc_mediabus.c | 65 ++ include/linux/platform_data/media/camera-pxa.h | 2 + include/media/drv-intf/soc_mediabus.h | 22 + include/media/soc_camera.h | 15 - 6 files changed, 708 insertions(+), 489 deletions(-) -- 2.1.4