Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753560AbcDBRRh (ORCPT ); Sat, 2 Apr 2016 13:17:37 -0400 Received: from pygmy.kinoho.net ([134.0.27.24]:38056 "EHLO pygmy.kinoho.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751991AbcDBRRd (ORCPT ); Sat, 2 Apr 2016 13:17:33 -0400 From: Grigori Goronzy To: Johan Hovold Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Grigori Goronzy Subject: [PATCH v2 02/14] USB: ch341: fix error handling on resume Date: Sat, 2 Apr 2016 19:07:11 +0200 Message-Id: <1459616843-23829-3-git-send-email-greg@chown.ath.cx> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1459616843-23829-1-git-send-email-greg@chown.ath.cx> References: <1459616843-23829-1-git-send-email-greg@chown.ath.cx> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 700 Lines: 24 This may fail, do not assume it always works. Signed-off-by: Grigori Goronzy --- drivers/usb/serial/ch341.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c index 43e4594..9fb9089 100644 --- a/drivers/usb/serial/ch341.c +++ b/drivers/usb/serial/ch341.c @@ -545,9 +545,7 @@ static int ch341_reset_resume(struct usb_serial *serial) priv = usb_get_serial_port_data(serial->port[0]); /* reconfigure ch341 serial port after bus-reset */ - ch341_configure(serial->dev, priv); - - return 0; + return ch341_configure(serial->dev, priv); } static struct usb_serial_driver ch341_device = { -- 1.9.1