Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751907AbcDBRrw (ORCPT ); Sat, 2 Apr 2016 13:47:52 -0400 Received: from smtp1.ono.com ([62.42.230.162]:48738 "EHLO smtp1.ono.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbcDBRrv (ORCPT ); Sat, 2 Apr 2016 13:47:51 -0400 X-CTCH-RefID: str=0001.0A0B0204.570005BC.004F,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown From: Iban Rodriguez To: David Kershner , Greg Kroah-Hartman , Benjamin Romer , Tim Sell , Neil Horman Cc: sparmaintainer@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Iban Rodriguez Subject: Staging: unisys/verisonic: Correct double unlock Date: Sat, 2 Apr 2016 19:47:06 +0200 Message-Id: <1459619226-9786-1-git-send-email-iban.rodriguez@ono.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 969 Lines: 23 'priv_lock' is unlocked twice. The first one is removed and the function 'visornic_serverdown_complete' is now called with 'priv_lock' locked because 'devdata' is modified inside. Signed-off-by: Iban Rodriguez --- drivers/staging/unisys/visornic/visornic_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c index be0d057346c3..af03f2938fe9 100644 --- a/drivers/staging/unisys/visornic/visornic_main.c +++ b/drivers/staging/unisys/visornic/visornic_main.c @@ -368,7 +368,6 @@ visornic_serverdown(struct visornic_devdata *devdata, } devdata->server_change_state = true; devdata->server_down_complete_func = complete_func; - spin_unlock_irqrestore(&devdata->priv_lock, flags); visornic_serverdown_complete(devdata); } else if (devdata->server_change_state) { dev_dbg(&devdata->dev->device, "%s changing state\n", -- 1.9.1