Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752127AbcDBUw5 (ORCPT ); Sat, 2 Apr 2016 16:52:57 -0400 Received: from mail.skyhub.de ([78.46.96.112]:51789 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbcDBUwz (ORCPT ); Sat, 2 Apr 2016 16:52:55 -0400 Date: Sat, 2 Apr 2016 22:52:48 +0200 From: Borislav Petkov To: Andy Lutomirski Cc: Andy Lutomirski , X86 ML , Paolo Bonzini , Peter Zijlstra , KVM list , Arjan van de Ven , xen-devel , "linux-kernel@vger.kernel.org" , Linus Torvalds , Andrew Morton Subject: Re: [PATCH v5 4/9] x86/traps: Enable all exception handler callbacks early Message-ID: <20160402205248.GD2538@pd.tnic> References: <20fc047d926150cb08cb9b9f2923519b07ec1a15.1459605520.git.luto@kernel.org> <20160402185227.GB2538@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 966 Lines: 24 On Sat, Apr 02, 2016 at 01:16:07PM -0700, Andy Lutomirski wrote: > I have no idea why it was explicitly unsupported, but I'm guessing it > was just to avoid duplicating the code. Early "ext" uaccess failures > are certainly not going to work, but I don't think this is a problem > -- there's no userspace before trap_init runs, so how exactly is an > "ext" uaccess going to happen in the first place? > > In any event, if it did happen in older kernels, it would have > immediately panicked due to that code. At least with my code it just > might manage to EFAULT correctly. Yeah, I was wondering what that early thing meant. Linus or tip guys probably remember what this whole deal with early uaccess was about. I'll try to do some git archeology tomorrow. In any event, it would be a good idea IMO, to hold that situation down in a comment somewhere. Once we've figured it out... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.