Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752618AbcDCIlj (ORCPT ); Sun, 3 Apr 2016 04:41:39 -0400 Received: from mail.skyhub.de ([78.46.96.112]:46377 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752138AbcDCIlg (ORCPT ); Sun, 3 Apr 2016 04:41:36 -0400 Date: Sun, 3 Apr 2016 10:41:29 +0200 From: Borislav Petkov To: Andy Lutomirski Cc: X86 ML , Paolo Bonzini , Peter Zijlstra , KVM list , Arjan van de Ven , xen-devel , linux-kernel@vger.kernel.org, Linus Torvalds , Andrew Morton Subject: Re: [PATCH v5 5/9] x86/paravirt: Add _safe to the read_msr and write_msr PV hooks Message-ID: <20160403084129.GB19007@pd.tnic> References: <9ee3fb6a196a514c93325bdfa15594beecf04876.1459605520.git.luto@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9ee3fb6a196a514c93325bdfa15594beecf04876.1459605520.git.luto@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1605 Lines: 48 On Sat, Apr 02, 2016 at 07:01:36AM -0700, Andy Lutomirski wrote: > These hooks match the _safe variants, so name them accordingly. > This will make room for unsafe PV hooks. > > Signed-off-by: Andy Lutomirski > --- > arch/x86/include/asm/paravirt.h | 33 +++++++++++++++++---------------- > arch/x86/include/asm/paravirt_types.h | 8 ++++---- > arch/x86/kernel/paravirt.c | 4 ++-- > arch/x86/xen/enlighten.c | 4 ++-- > 4 files changed, 25 insertions(+), 24 deletions(-) ... > diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h > index 77db5616a473..5a06cccd36f0 100644 > --- a/arch/x86/include/asm/paravirt_types.h > +++ b/arch/x86/include/asm/paravirt_types.h > @@ -155,10 +155,10 @@ struct pv_cpu_ops { > void (*cpuid)(unsigned int *eax, unsigned int *ebx, > unsigned int *ecx, unsigned int *edx); > > - /* MSR, PMC and TSR operations. > - err = 0/-EFAULT. wrmsr returns 0/-EFAULT. */ > - u64 (*read_msr)(unsigned int msr, int *err); > - int (*write_msr)(unsigned int msr, unsigned low, unsigned high); > + /* MSR operations. > + err = 0/-EIO. wrmsr returns 0/-EIO. */ Please reformat this comment properly, while you're at it: /* * A sentence. * Another sentence. */ > + u64 (*read_msr_safe)(unsigned int msr, int *err)Please reformat this > comment properly, while you're at it: > + int (*write_msr_safe)(unsigned int msr, unsigned low, unsigned high); > > u64 (*read_pmc)(int counter); > -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.