Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754005AbcDCOKv (ORCPT ); Sun, 3 Apr 2016 10:10:51 -0400 Received: from mail.skyhub.de ([78.46.96.112]:33620 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753846AbcDCOKt (ORCPT ); Sun, 3 Apr 2016 10:10:49 -0400 Date: Sun, 3 Apr 2016 16:10:41 +0200 From: Borislav Petkov To: Andy Lutomirski Cc: Linus Torvalds , "H. Peter Anvin" , Andy Lutomirski , X86 ML , Paolo Bonzini , Peter Zijlstra , KVM list , Arjan van de Ven , xen-devel , "linux-kernel@vger.kernel.org" , Andrew Morton Subject: Re: [PATCH v5 4/9] x86/traps: Enable all exception handler callbacks early Message-ID: <20160403141041.GE19007@pd.tnic> References: <20fc047d926150cb08cb9b9f2923519b07ec1a15.1459605520.git.luto@kernel.org> <20160402185227.GB2538@pd.tnic> <20160402205248.GD2538@pd.tnic> <20160403080737.GA19007@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1071 Lines: 32 On Sun, Apr 03, 2016 at 06:55:00AM -0700, Andy Lutomirski wrote: > > No, please don't fail at early boot. > > > > Early boot is just about the *worst* situation to try to debug odd > > failures, exactly since things like printk may not be reliable, and > > things won't get logged etc. > > > > So particularly during early boot we should try as hard as possible > > not to crash - even if it means not being able to log about a problem. > > At least that way you have a hopefully working machine and can *maybe* > > debug things. > > > > In this regard, at least, my patch is the right approach. Calling the > handler, whatever it is, is less likely to panic than refusing to call > it. Ok, good. But can we pretty please document this whole situation, i.e., the fact that we're trying really really hard not to fail early boot for debuggability reasons - either in the commit message or better in the code, for future reference. I think this is an important aspect to hold down. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.