Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752853AbcDCT2u (ORCPT <rfc822;w@1wt.eu>);
	Sun, 3 Apr 2016 15:28:50 -0400
Received: from mail-oi0-f43.google.com ([209.85.218.43]:36666 "EHLO
	mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751983AbcDCT2t (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 3 Apr 2016 15:28:49 -0400
MIME-Version: 1.0
In-Reply-To: <1459589383-16914-5-git-send-email-guodong.xu@linaro.org>
References: <1459589383-16914-1-git-send-email-guodong.xu@linaro.org>
	<1459589383-16914-5-git-send-email-guodong.xu@linaro.org>
Date: Sun, 3 Apr 2016 21:28:48 +0200
Message-ID: <CACRpkdb8x1EVMDgrV36+neGk1O+rGnSpj9F0A5stHN_d6B-EAA@mail.gmail.com>
Subject: Re: [PATCH v2 04/16] arm64: dts: Add Hi6220 gpio configuration nodes
From: Linus Walleij <linus.walleij@linaro.org>
To: Guodong Xu <guodong.xu@linaro.org>
Cc: Xu Wei <xuwei5@hisilicon.com>, Mark Rutland <mark.rutland@arm.com>,
        Rob Herring <robh@kernel.org>,
        Grant Likely <grant.likely@secretlab.ca>,
        Arnd Bergmann <arnd.bergmann@linaro.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        XinWei Kong <kong.kongxinwei@hisilicon.com>,
        Zhong Kaihua <zhongkaihua@huawei.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2207
Lines: 74

On Sat, Apr 2, 2016 at 11:29 AM, Guodong Xu <guodong.xu@linaro.org> wrote:

> From: Zhong Kaihua <zhongkaihua@huawei.com>
>
> Add Hi6220 gpio configuration nodes
>
> Signed-off-by: Zhong Kaihua <zhongkaihua@huawei.com>
> Signed-off-by: Kong Xinwei <kong.kongxinwei@hisilicon.com>
>

Get rid of that blank line.

> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Wei Xu <xuwei5@hisilicon.com>

> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -249,5 +249,264 @@
>                         clocks = <&ao_ctrl 27>;
>                         clock-names = "apb_pclk";
>                 };
> +
> +               gpio0: gpio@f8011000 {
> +                       compatible = "arm,pl061", "arm,primecell";
> +                       reg = <0x0 0xf8011000 0x0 0x1000>;
> +                       interrupts = <0 52 0x4>;
> +                       gpio-controller;
> +                       #gpio-cells = <2>;
> +                       interrupt-controller;
> +                       #interrupt-cells = <2>;
> +                       clocks = <&ao_ctrl 2>;
> +                       clock-names = "apb_pclk";
> +                       status = "ok";
> +               };

This part with all GPIO controllers looks nice.

> new file mode 100644
> index 0000000..09242f0
> --- /dev/null
> +++ b/arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi
> @@ -0,0 +1,607 @@
> +/ {
> +       gpio_rstout_n:gpio_rstout_n {
> +               gpios;
> +       };
> +       gpio_pmu_peri_en:gpio_pmu_peri_en {
> +               gpios;
> +       };
> +       gpio_sysclk0_en:gpio_sysclk0_en {
> +               gpios;
> +       };
> +       gpio_jtag_tdo:gpio_jtag_tdo {
> +               gpios;
> +       };
> +       /* LCB: PWR_HOLD_GPIO0_0 */
> +       gpio_pwr_hold:gpio_pwr_hold {
> +               gpios = <&gpio0 0 0>;
> +       };

(...)

I don't understand any stuff in this hikey-gpio.dtsi file.

What does all this mean?

If it has any practical use whatsoever then explain it in the
commit message, but right now it just looks like a big list
of placeholders with no use, but you can copy-paste them
into device nodes the day you need them?

If they are unused, just drop this file please.

Yours,
Linus Walleij