Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753810AbcDDGav (ORCPT ); Mon, 4 Apr 2016 02:30:51 -0400 Received: from mga02.intel.com ([134.134.136.20]:52368 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751310AbcDDGat (ORCPT ); Mon, 4 Apr 2016 02:30:49 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,439,1455004800"; d="asc'?scan'208";a="924809109" From: Felipe Balbi To: santosh shilimkar , Grygorii Strashko , "Thang Q. Nguyen" Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm@lists.infradead.org, Arnd Bergmann , "Karicheri\, Muralidharan" , Peter Ujfalusi , Phong Vo , Loc Ho , patches , Santosh Shilimkar , "Ben Dooks \(embedded platforms\)" , Arnd Bergmann , Russell King Subject: Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child In-Reply-To: <56FEBAC1.2040509@oracle.com> References: <1457594332-7490-1-git-send-email-tqnguyen@apm.com> <1457594332-7490-3-git-send-email-tqnguyen@apm.com> <87mvpgi02f.fsf@intel.com> <56FBDA0D.4030507@ti.com> <87egashxz8.fsf@intel.com> <87k2kjgjjf.fsf@intel.com> <56FD3D2F.8070501@ti.com> <871t6pahg8.fsf@intel.com> <56FE4378.3030205@ti.com> <87shz58wbw.fsf@intel.com> <56FE54DB.5000201@ti.com> <878u0x8ru4.fsf@intel.com> <56FEBAC1.2040509@oracle.com> User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Mon, 04 Apr 2016 09:28:14 +0300 Message-ID: <87oa9p7url.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2520 Lines: 74 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable santosh shilimkar writes: > +Arnd, RMK, > > On 4/1/2016 4:57 AM, Felipe Balbi wrote: >> >> Hi, >> >> Grygorii Strashko writes: >>> On 04/01/2016 01:20 PM, Felipe Balbi wrote: > > [...] > >>> commit 7ace8fc8219e4cbbfd5b4790390d9a01a2541cdf >>> Author: Yoshihiro Shimoda >>> Date: Mon Jul 13 18:10:05 2015 +0900 >>> >>> usb: gadget: udc: core: Fix argument of dma_map_single for IOMMU >>> >>> The dma_map_single and dma_unmap_single should set "gadget->dev.pa= rent" >>> instead of "&gadget->dev" in the first argument because the parent= has >>> a udc controller's device pointer. >>> Otherwise, iommu functions are not called in ARM environment. >>> >>> Signed-off-by: Yoshihiro Shimoda >>> Signed-off-by: Felipe Balbi >>> >>> Above actually means that DMA configuration code can be dropped from >>> usb_add_gadget_udc_release() completely. Right?: >> >> true, but now I'm not sure what's better: copy all necessary bits from >> parent or just pass the parent device to all DMA API. >> >> Anybody to shed a light here ? >> > The expectation is drivers should pass the proper dev pointers and let=20 > core DMA code deal with it since it knows the per device dma properties. okay, so how do you get proper DMA pointers with something like this: kdwc3_dma_mask =3D dma_get_mask(dev); dev->dma_mask =3D &kdwc3_dma_mask; This doesn't anything. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXAgl/AAoJEIaOsuA1yqREasYP/R2cBnfVQwZ/e5SpOVDGCEKU wXSSPz7G+jCJoad7BawgZWnEkoYUFazrQNknDtW0/mTCmuwmRkrYmSFJOPNIXV7P 66yuhcUhQZEWG3fzjIVLbb2+gnh25zBzPvBt6dMNj0BI3CvGTzjxTg0lLY23Aqb/ OoTJLDCQLN49CTpd5g5gDw4NMt1+IaCT/tystX8fc3yS9Pq0tUnwCdu0+9e9D3IF KiVgkFQ6i3YdcJvm1yWZ4Si9Ivws5m30Hc0vJUkMFfe/VJvW1pVcdPpd1r21/Y4/ CV2y6XeA6GbLpSZAtawWb/QkL2OFgGXzoojnvn4GDwUAKjQmV1gmknxwU7auGdrG otdhRlL4ID3FLG2fwrlec4Ol/xQYbUNfy9l4jSs0Faf6uRGe6vL2laF0RCMGZqjW 4uCRz0zE2ecrPbOXmCPWsnGalQRsW0+BtYxrKIqni27ZpY7dmJ19pyf3kp8QN5P3 FqmQJvO6BbjO69qfvUjSKPZHKgpGMRVZZ7hWHUAv3Qx6hm/CW9uRbEbRaLTXhVCW XsiqeZdb2O9ddzGMAcIpkSuExCdHyMiMepDhip9NJYlA5BWGe8xNbuueyH2Jxa5v +61Td01U0KOrV47ETWmROEaEXE0zY3GPFCaEb5zuMo6KTYjGQ91kOOkPEELu3r9F xyU0NbikAzeV6A6VGZf4 =QbeW -----END PGP SIGNATURE----- --=-=-=--