Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754240AbcDDHNI (ORCPT ); Mon, 4 Apr 2016 03:13:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:49287 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010AbcDDHNH (ORCPT ); Mon, 4 Apr 2016 03:13:07 -0400 Message-ID: <1459753985.24025.7.camel@suse.com> Subject: Re: [PATCH v2 05/14] USB: ch341: fix USB buffer allocations From: Oliver Neukum To: Grigori Goronzy Cc: Johan Hovold , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Date: Mon, 04 Apr 2016 09:13:05 +0200 In-Reply-To: <1459616843-23829-6-git-send-email-greg@chown.ath.cx> References: <1459616843-23829-1-git-send-email-greg@chown.ath.cx> <1459616843-23829-6-git-send-email-greg@chown.ath.cx> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1481 Lines: 51 On Sat, 2016-04-02 at 19:07 +0200, Grigori Goronzy wrote: > Use the correct types and sizes. > > Signed-off-by: Grigori Goronzy > --- > drivers/usb/serial/ch341.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c > index 25c5d8d..6781911 100644 > --- a/drivers/usb/serial/ch341.c > +++ b/drivers/usb/serial/ch341.c > @@ -116,7 +116,7 @@ static int ch341_control_out(struct usb_device *dev, u8 request, > > static int ch341_control_in(struct usb_device *dev, > u8 request, u16 value, u16 index, > - char *buf, unsigned bufsize) > + unsigned char *buf, unsigned bufsize) If you do that, you can just use u8 * > { > int r; > > @@ -169,9 +169,9 @@ static int ch341_set_handshake(struct usb_device *dev, u8 control) > > static int ch341_get_status(struct usb_device *dev, struct ch341_private *priv) > { > - char *buffer; > + unsigned char *buffer; > int r; > - const unsigned size = 8; > + const unsigned size = 2; > unsigned long flags; > > buffer = kmalloc(size, GFP_KERNEL); > @@ -199,9 +199,9 @@ out: kfree(buffer); > > static int ch341_configure(struct usb_device *dev, struct ch341_private *priv) > { > - char *buffer; > + unsigned char *buffer; > int r; > - const unsigned size = 8; > + const unsigned size = 2; Are you sure only 2 are used? For the amount of space needed it makes no difference. Regards Oliver