MIME-Version: 1.0
In-Reply-To: <1459616904-1682-2-git-send-email-treeze.taeung@gmail.com>
References: <1459616904-1682-1-git-send-email-treeze.taeung@gmail.com> <1459616904-1682-2-git-send-email-treeze.taeung@gmail.com>
From: Masami Hiramatsu <mhiramat@kernel.org>
Date: Mon, 4 Apr 2016 17:13:31 +0900
Message-ID: <CADyE4xGtr-54PThpkwgPUiSaxT1FtfLBRjAAsLkYEwz6P8783g@mail.gmail.com>
Subject: Re: [PATCH v5 1/4] perf config: Introduce perf_config_set class
To: Taeung Song <treeze.taeung@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, linux-kernel@vger.kernel.org,
        Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
        Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1471
Lines: 53

Hi,

2016-04-03 2:08 GMT+09:00 Taeung Song <treeze.taeung@gmail.com>:
[...]
> +static struct perf_config_section *add_section(struct list_head *sections,
> +                                              const char *section_name)
> +{
> +       struct perf_config_section *section = zalloc(sizeof(*section));
> +
> +       if (!section)
> +               return NULL;
> +
> +       INIT_LIST_HEAD(&section->items);
> +       section->name = strdup(section_name);
> +       if (!section->name) {
> +               pr_debug("%s: strdup failed\n", __func__);
> +               free(section);
> +               return NULL;
> +       }
> +
> +       list_add_tail(&section->node, sections);
> +       return section;
> +}
> +
> +static struct perf_config_item *add_config_item(struct perf_config_section *section,
> +                                               const char *name)
> +{
> +       struct perf_config_item *item = zalloc(sizeof(*item));
> +
> +       if (!item)
> +               return NULL;
> +
> +       item->name = strdup(name);
> +       if (!item->name) {
> +               pr_debug("%s: strdup failed\n", __func__);
> +               goto out_err;

As you did in above add_section(), you can do free(item)
and return NULL here instead of using goto.

Other parts looks OK for me.

Thank you,

> +       }
> +
> +       list_add_tail(&item->node, &section->items);
> +       return item;
> +
> +out_err:
> +       free(item);
> +       return NULL;
> +}