Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755054AbcDDKcM (ORCPT ); Mon, 4 Apr 2016 06:32:12 -0400 Received: from smtprelay2.synopsys.com ([198.182.60.111]:46120 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754611AbcDDKcJ (ORCPT ); Mon, 4 Apr 2016 06:32:09 -0400 Subject: Re: [PATCH 8/8] scsi: ufs: connect to RPMB subsystem To: Tomas Winkler , , "Ulf Hansson" , Adrian Hunter , James Bottomley , "Martin K. Petersen" , Vinayak Holikatti References: <1459676572-29921-1-git-send-email-tomas.winkler@intel.com> <1459676572-29921-9-git-send-email-tomas.winkler@intel.com> CC: Christoph Hellwig , Yaniv Gardi , "Joao Pinto" , , , , "Alexander Usyskin" From: Joao Pinto Message-ID: <570242A1.6020501@synopsys.com> Date: Mon, 4 Apr 2016 11:32:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1459676572-29921-9-git-send-email-tomas.winkler@intel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.13.184.19] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1990 Lines: 58 Hi! On 4/3/2016 10:42 AM, Tomas Winkler wrote: > Register UFS RPMB LUN with the RPMB subsystem and provide > implementation for the RPMB access operations. RPMB partition is > accessed via a sequence of security protocol in and security protocol > out commands with UFS specific parameters. This multi step process is > abstracted into 4 basic RPMB commands. > > Signed-off-by: Alexander Usyskin > Signed-off-by: Tomas Winkler > --- > drivers/scsi/ufs/ufshcd.c | 219 ++++++++++++++++++++++++++++++++++++++++++++++ > drivers/scsi/ufs/ufshcd.h | 2 + > 2 files changed, 221 insertions(+) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index f8fa72c31a9d..c087e9713db3 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -37,10 +37,13 @@ > * license terms, and distributes only under these terms. > */ > [snip] > scsi_remove_host(hba->host); > /* disable interrupts */ > ufshcd_disable_intr(hba, hba->intr_mask); > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h > index 4bb65669f052..92bfddf80ae8 100644 > --- a/drivers/scsi/ufs/ufshcd.h > +++ b/drivers/scsi/ufs/ufshcd.h > @@ -346,6 +346,7 @@ struct ufs_init_prefetch { > * @utmrdl_dma_addr: UTMRDL DMA address > * @host: Scsi_Host instance of the driver > * @dev: device handle > + * @sdev_ufs_rpmb: reference to RPMB device W-LU > * @lrb: local reference block > * @lrb_in_use: lrb in use > * @outstanding_tasks: Bits representing outstanding task requests > @@ -408,6 +409,7 @@ struct ufs_hba { > * "UFS device" W-LU. > */ > struct scsi_device *sdev_ufs_device; > + struct scsi_device *sdev_ufs_rpmb; > > enum ufs_dev_pwr_mode curr_dev_pwr_mode; > enum uic_link_state uic_link_state; > I saw some kbuild robot issues regarding the patchset, so I would suggest you make a v2 of the patch set and I can run some tests with the DW UFS Host design. Thanks. Joao