Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755365AbcDDLwB (ORCPT ); Mon, 4 Apr 2016 07:52:01 -0400 Received: from kiutl.biot.com ([31.172.244.210]:45946 "EHLO kiutl.biot.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753436AbcDDLwA (ORCPT ); Mon, 4 Apr 2016 07:52:00 -0400 Subject: Re: [PATCH] ARM: dts: kirkwood: Add DTS for Linksys EA4200v2/EA4500 To: Andrew Lunn References: <1459601753-31193-1-git-send-email-bert@biot.com> <20160402161639.GF32554@lunn.ch> Cc: Jason Cooper , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , "moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,..." , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list From: Bert Vermeulen Message-ID: <5702555C.1020408@biot.com> Date: Mon, 4 Apr 2016 13:51:56 +0200 MIME-Version: 1.0 In-Reply-To: <20160402161639.GF32554@lunn.ch> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1347 Lines: 38 On 04/02/2016 06:16 PM, Andrew Lunn wrote: > On Sat, Apr 02, 2016 at 02:55:52PM +0200, Bert Vermeulen wrote: >> + * (c) 2013 Jonas Gorski >> + * (c) 2013 Deutsche Telekom Innovation Laboratories >> + * (c) 2014 Luka Perkov >> + * (c) 2014 Randy C. Will >> + * >> + * This file is licensed under the terms of the GNU General Public >> + * License version 2. This program is licensed "as is" without any >> + * warranty of any kind, whether express or implied. >> + */ > > Could you dual license this under X11 as well? You will need agreement > from the copyright holders above, if they wrote DT fragments. > > Not many kirkwood boards are, but we encourage most Marvell SoCs DT > files to be dual license. I did not get responses from all authors, so no dice. >> + chosen { >> + bootargs = "console=ttyS0,115200n8 earlyprintk"; > > Please change this to stdout-path = "serial0:115200n8"; I've added a serial alias (the actual label is uart0). That alias and one for serial1 might perhaps be better in kirkwood.dts, but I'll leave that up to you. > The 6171 is a 7 port device. Is the last port also a 'cpu' port? I don't think so. I didn't manage to get anything through it, and I can't see the CPU traces on the PCB (neither 5 nor 6). -- Bert Vermeulen bert@biot.com