Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755821AbcDDOBm (ORCPT ); Mon, 4 Apr 2016 10:01:42 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:59172 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755795AbcDDOBk (ORCPT ); Mon, 4 Apr 2016 10:01:40 -0400 Message-ID: <1459778496.2315.1.camel@HansenPartnership.com> Subject: Re: [PATCH v2 0/5] mempool based chained scatterlist alloc/free api From: James Bottomley To: Ming Lin Cc: Christoph Hellwig , lkml , "linux-scsi@vger.kernel.org" Date: Mon, 04 Apr 2016 07:01:36 -0700 In-Reply-To: References: <1458684196-15923-1-git-send-email-mlin@kernel.org> <20160323074012.GA17929@lst.de> <1458834360.2544.12.camel@HansenPartnership.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1749 Lines: 56 On Sun, 2016-04-03 at 23:07 -0700, Ming Lin wrote: > On Mon, Mar 28, 2016 at 7:48 AM, Ming Lin wrote: > > On Thu, Mar 24, 2016 at 8:46 AM, James Bottomley > > wrote: > > > On Thu, 2016-03-24 at 08:09 -0700, Ming Lin wrote: > > > > On Wed, Mar 23, 2016 at 12:40 AM, Christoph Hellwig > > > > > > > > wrote: > > > > > On Tue, Mar 22, 2016 at 03:03:11PM -0700, Ming Lin wrote: > > > > > > From: Ming Lin > > > > > > > > > > > > The fist 4 patches make the SG related > > > > > > definitions/structs/functions > > > > > > in SCSI code generic and the last patch move it to > > > > > > lib/sg_pool.c. > > > > > > > > > > > > I still keep the macro "SG_MEMPOOL_NR" since it's used in 3 > > > > > > places. > > > > > > > > > > I don't ѕee the point, but I'm not going to block the series > > > > > over > > > > > it either. > > > > > > > > > > The new series looks really nice to me! > > > > > > > > > > Reviewed-by: Christoph Hellwig > > > > > > > > Hi James, > > > > > > > > This series touches several sub-systems. > > > > What's the best way to merge it? > > > > > > It has a minor intrusion into > > > > > > drivers/ata/pata_icside.c | 2 +- > > > drivers/infiniband/ulp/srp/ib_srp.c | 4 +- > > > drivers/usb/storage/scsiglue.c | 2 +- > > > > > > Apart from that, it's all SCSI, so the SCSI tree would seem to be > > > the > > > best one. > > > > Are you OK to merge it? > > Hi James, > > Ping ... > > Are you OK to apply this series? > Or any changes needed? It's got the needed reviews, but we need acks from tejun (ATA) and Sagi (IB) and a repost fixing the test robot objection to patch 5. James