Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932396AbcDDQD5 (ORCPT ); Mon, 4 Apr 2016 12:03:57 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:42858 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755616AbcDDQDy (ORCPT ); Mon, 4 Apr 2016 12:03:54 -0400 Date: Mon, 4 Apr 2016 09:03:27 -0700 From: Mark Brown To: Octavian Purdila Cc: "Rafael J. Wysocki" , "Rafael J. Wysocki" , Len Brown , Matt Fleming , Wolfram Sang , Joel Becker , Christoph Hellwig , "linux-acpi@vger.kernel.org" , linux-efi@vger.kernel.org, linux-i2c , linux-spi@vger.kernel.org, lkml , Irina Tirdea Message-ID: <20160404160327.GH2350@sirena.org.uk> References: <1459417026-6697-1-git-send-email-octavian.purdila@intel.com> <1459417026-6697-7-git-send-email-octavian.purdila@intel.com> <20160331172935.GL2350@sirena.org.uk> <20160401140856.GW2350@sirena.org.uk> <20160402162449.GB2350@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GH2w3bbsGmSMo31z" Content-Disposition: inline In-Reply-To: X-Cookie: If anything can go wrong, it will. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 209.65.105.100 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC PATCH 06/10] spi: add support for ACPI reconfigure notifications X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1725 Lines: 43 --GH2w3bbsGmSMo31z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 04, 2016 at 01:25:56PM +0300, Octavian Purdila wrote: > On Sat, Apr 2, 2016 at 7:24 PM, Mark Brown wrote: > > What I don't understand is why the flow on inital probe isn't simply to > > register the controller which then triggers the walk of the children. > > That way any bus that supports initial probe also supports hotplug > > without needing to go and manually add a second code path. > Do you mean register the notifier per controller instead of per > subsystem? Either way we need changes at the subsystem level and I > choose to follow the device tree implementation for consistency. No! I mean use the exact same callback you've got now for everything. > The other reason is that (pending other ACPICA changes) we can add > other notification events in the future such as node added or removed > (just like device tree), and in that case the probe and hotplug > handling would be different (and a bit more efficient). Why is probe different to hotplug? We don't need to do that in the normal driver model. --GH2w3bbsGmSMo31z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXApBKAAoJECTWi3JdVIfQi4UH/0n5ctuTiNy19NukG3EILHSB mD92PAk3ysfpgYqCY3v+x0V3UiEhbhDIflrSpi0IiKIaMu8M+7K3gJKjeVo1Jd6b JSKVE0lsLzXkM9cQs7nE/eg0zXcpSx/uHE5ilfxZsZpPcaWG0demluZmHDtAczKb saOInORaXf5JtzjVlwHWa001SFRSRuDciSCRZS9lm5XHjgFgzlXLrMbA3tbsHh1W pKVnoddslbAL8DDxZU59NtizJhc9HTA74JIG50ZqNRgsb1aa8cD+ez3drA5pnLMD AVLhHy5IwWjCKVf3CphJAEYXKdWiLYekFZpnFVDVelzQ7qt4IyKYG+x80S/rIJU= =fMiN -----END PGP SIGNATURE----- --GH2w3bbsGmSMo31z--