Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932649AbcDDQcY (ORCPT <rfc822;w@1wt.eu>);
	Mon, 4 Apr 2016 12:32:24 -0400
Received: from smtp.citrix.com ([66.165.176.89]:30894 "EHLO SMTP.CITRIX.COM"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932428AbcDDQcU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 4 Apr 2016 12:32:20 -0400
X-IronPort-AV: E=Sophos;i="5.24,441,1454976000"; 
   d="scan'208";a="344653211"
Subject: Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier
 transitions
To: Julien Grall <julien.grall@arm.com>,
        Anna-Maria Gleixner <anna-maria@linutronix.de>,
        <linux-kernel@vger.kernel.org>
References: <1459773140-43707-1-git-send-email-anna-maria@linutronix.de>
 <57029499.7070007@arm.com>
CC: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
        <rt@linutronix.de>, David Vrabel <david.vrabel@citrix.com>,
        Boris Ostrovsky <Boris.Ostrovsky@oracle.com>,
        Juergen Gross <JGross@suse.com>
From: David Vrabel <david.vrabel@citrix.com>
Message-ID: <570296C3.70805@citrix.com>
Date: Mon, 4 Apr 2016 17:30:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.5.0
MIME-Version: 1.0
In-Reply-To: <57029499.7070007@arm.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-DLP: MIA1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1091
Lines: 33

On 04/04/16 17:21, Julien Grall wrote:
> (CC Stefano new e-mail address)
> 
> Hello Anna-Maria,
> 
> On 04/04/2016 13:32, Anna-Maria Gleixner wrote:
>> Xen guests do not offline/online CPUs during suspend/resume and
>> therefore FROZEN notifier transitions are not required. Add this
>> explanation as a comment in the code to get not confused why
>> CPU_TASKS_FROZEN masked transitions are not considered.

Alternatively, these could be added even if they are not encountered.
This might be more future-proof but the documentation might be clearer.

Boris, Juergen, any opinion?

David>> --- a/drivers/xen/events/events_fifo.c
>> +++ b/drivers/xen/events/events_fifo.c
>> @@ -425,6 +425,12 @@ static int evtchn_fifo_cpu_notification(
>>       int cpu = (long)hcpu;
>>       int ret = 0;
>>
>> +    /*
>> +     * Xen guests do not offline/online CPUs during
>> +     * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
>> +     * are not considered.
>> +    */
> 
> NIT: The '*' is not aligned with the others.

If this doesn't need any other changes, I'll fix this on commit.

David