Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755908AbcDDSSq (ORCPT ); Mon, 4 Apr 2016 14:18:46 -0400 Received: from a.ns.miles-group.at ([95.130.255.143]:11949 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754591AbcDDSSp (ORCPT ); Mon, 4 Apr 2016 14:18:45 -0400 Subject: Re: [PATCH] mtd: gpmi: fix raw_buffer pointer double free issue To: Han Xu , boris.brezillon@free-electrons.com, dwmw2@infradead.org, computersforpeace@gmail.com References: <1459790710-25747-1-git-send-email-han.xu@nxp.com> Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org From: Richard Weinberger Message-ID: <5702AFFF.1010700@nod.at> Date: Mon, 4 Apr 2016 20:18:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1459790710-25747-1-git-send-email-han.xu@nxp.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 883 Lines: 27 Am 04.04.2016 um 19:25 schrieb Han Xu: > fix the raw_buffer pointer double free issue found by coverify. Can you please include the coverity message in you changelog? > Signed-off-by: Han Xu > --- > drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > index 8122c69..dcb60b0 100644 > --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > @@ -797,6 +797,7 @@ static void gpmi_free_dma_buffer(struct gpmi_nand_data *this) > > this->cmd_buffer = NULL; > this->data_buffer_dma = NULL; > + this->raw_buffer = NULL; > this->page_buffer_virt = NULL; > this->page_buffer_size = 0; So, gpmi_free_dma_buffer() is called twice and therefore we need to NULL all these pointers? Thanks, //richard