Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756718AbcDDU27 (ORCPT ); Mon, 4 Apr 2016 16:28:59 -0400 Received: from mga09.intel.com ([134.134.136.24]:54859 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756467AbcDDU26 (ORCPT ); Mon, 4 Apr 2016 16:28:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,442,1455004800"; d="scan'208";a="947891290" From: kan.liang@intel.com To: acme@kernel.org Cc: jolsa@redhat.com, ak@linux.intel.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, Kan Liang Subject: [PATCH 1/1] perf tools: Fix format value calculation Date: Mon, 4 Apr 2016 06:12:54 -0700 Message-Id: <1459775574-7595-1-git-send-email-kan.liang@intel.com> X-Mailer: git-send-email 2.5.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1382 Lines: 47 From: Kan Liang The calculation of format value also rely on the continuity of the format. However, uncore event format is not continuous. E.g. The bit 21 as qpi event is lost. perf stat -a -e uncore_qpi_0/event=0x200038,config1=0x1C00, config2=0x3FE00/ -vvv ------------------------------------------------------------ perf_event_attr: type 10 size 112 config 0x38 This patch checks the bit according to the bit position. Signed-off-by: Kan Liang --- tools/perf/util/pmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index bf34468..47c096c 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -586,14 +586,14 @@ __u64 perf_pmu__format_bits(struct list_head *formats, const char *name) static void pmu_format_value(unsigned long *format, __u64 value, __u64 *v, bool zero) { - unsigned long fbit, vbit; + unsigned long fbit; - for (fbit = 0, vbit = 0; fbit < PERF_PMU_FORMAT_BITS; fbit++) { + for (fbit = 0; fbit < PERF_PMU_FORMAT_BITS; fbit++) { if (!test_bit(fbit, format)) continue; - if (value & (1llu << vbit++)) + if (value & (1llu << fbit)) *v |= (1llu << fbit); else if (zero) *v &= ~(1llu << fbit); -- 2.5.5