Message-ID: <1459814150.2138.3.camel@perches.com>
Subject: Re: [PATCH v2 3/8] lib/uuid: introduce few more generic helpers for
 UUID
From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>, "Theodore Ts'o" <tytso@mit.edu>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
        linux-api@vger.kernel.org
Date: Mon, 04 Apr 2016 16:55:50 -0700
In-Reply-To: <20160404164029.9c72a93cb29d619766fbb2d2@linux-foundation.org>
References: <1459776610-68469-1-git-send-email-andriy.shevchenko@linux.intel.com>
	 <1459776610-68469-4-git-send-email-andriy.shevchenko@linux.intel.com>
	 <20160404164029.9c72a93cb29d619766fbb2d2@linux-foundation.org>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1510
Lines: 58

On Mon, 2016-04-04 at 16:40 -0700, Andrew Morton wrote:
> On Mon,??4 Apr 2016 16:30:05 +0300 Andy Shevchenko  wrote:
> 
> > 
> > There are new helpers in this patch:
> > 
> > uuid_is_valid		checks if a UUID is valid
> > uuid_be_to_bin		converts from string to binary (big endian)
> > uuid_le_to_bin		converts from string to binary (little endian)
> 	>?
> > 
> > They will be used in future, i.e. in the following patches in the series.
> > 
> > This also moves indices arrays to lib/uuid.c to be shared accross modules.
> > 
> > ...
> > 
> > --- a/include/linux/uuid.h
> > +++ b/include/linux/uuid.h
> Nit:
> 
> > 
> > +/**
> > +??* uuid_is_valid - checks if UUID string valid
> > +??* @uuid:	UUID string to check
> > +??*
> > +??* Description:
> > +??* It checks if the UUID string is following the format:
> > +??*	xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
> > +??* where x is a hex digit.
> > +??*
> > +??* Return: 0 on success, %-EINVAL otherwise.
> > +??*/
> > +int uuid_is_valid(const char *uuid)
> > +{
> > +	unsigned int i;
> > +
> > +	if (strnlen(uuid, UUID_STRING_LEN) < UUID_STRING_LEN)
> > +		return -EINVAL;
> > +
> > +	for (i = 0; i < UUID_STRING_LEN; i++) {
> > +		if (i == 8 || i == 13 || i == 18 || i == 23) {
> > +			if (uuid[i] != '-')
> > +				return -EINVAL;
> > +		} else if (!isxdigit(uuid[i])) {
> > +			return -EINVAL;
> > +		}
> > +	}
> Could add
> 
> 	if (uuid[i])
> 		return -EINVAL;
> 
> here and lose the additional pass across the input (strlen).

nit2:

Could make this return bool.