Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755083AbcDEDkK (ORCPT ); Mon, 4 Apr 2016 23:40:10 -0400 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:56836 "EHLO e23smtp05.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752767AbcDEDkI (ORCPT ); Mon, 4 Apr 2016 23:40:08 -0400 X-IBM-Helo: d23dlp01.au.ibm.com X-IBM-MailFrom: aneesh.kumar@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org From: "Aneesh Kumar K.V" To: Joonsoo Kim , Andrew Morton Cc: Rik van Riel , Johannes Weiner , Mel Gorman , Laura Abbott , Minchan Kim , Marek Szyprowski , Michal Nazarewicz , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] mm/writeback: correct dirty page calculation for highmem In-Reply-To: <20160405013613.GA27945@js1304-P5Q-DELUXE> References: <1459476610-31076-1-git-send-email-iamjoonsoo.kim@lge.com> <20160405013613.GA27945@js1304-P5Q-DELUXE> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 05 Apr 2016 09:08:47 +0530 Message-ID: <87a8l8ybaw.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16040503-0017-0000-0000-00000417337B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1102 Lines: 32 Joonsoo Kim writes: > [ text/plain ] > On Fri, Apr 01, 2016 at 11:10:07AM +0900, js1304@gmail.com wrote: >> From: Joonsoo Kim >> >> ZONE_MOVABLE could be treated as highmem so we need to consider it for >> accurate calculation of dirty pages. And, in following patches, ZONE_CMA >> will be introduced and it can be treated as highmem, too. So, instead of >> manually adding stat of ZONE_MOVABLE, looping all zones and check whether >> the zone is highmem or not and add stat of the zone which can be treated >> as highmem. >> >> Signed-off-by: Joonsoo Kim >> --- >> mm/page-writeback.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) > > Hello, Andrew. > > Could you review and merge these simple fixup and cleanup patches? > I'd like to send ZONE_CMA patchset v2 based on linux-next after this > series is merged to linux-next. > I searched with ZONE_HIGHMEM and AFAICS this series do handle all the highmem path. For the series: Reviewed-by: Aneesh Kumar K.V -aneesh