Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756618AbcDEDla (ORCPT ); Mon, 4 Apr 2016 23:41:30 -0400 Received: from mailout.easymail.ca ([64.68.201.169]:58772 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752085AbcDEDl3 (ORCPT ); Mon, 4 Apr 2016 23:41:29 -0400 X-Spam-Flag: NO X-Spam-Score: -3.695 From: Shuah Khan To: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Shuah Khan Subject: [PATCH] selftests: media_device_test fix to close the fd before exit Date: Mon, 4 Apr 2016 21:41:26 -0600 Message-Id: <1459827686-11155-1-git-send-email-shuahkh@osg.samsung.com> X-Mailer: git-send-email 2.5.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 969 Lines: 32 Fix it to close the fd before exit and in error legs. Signed-off-by: Shuah Khan --- tools/testing/selftests/media_tests/media_device_test.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/media_tests/media_device_test.c b/tools/testing/selftests/media_tests/media_device_test.c index cbf53a0..dfb3ca6 100644 --- a/tools/testing/selftests/media_tests/media_device_test.c +++ b/tools/testing/selftests/media_tests/media_device_test.c @@ -84,12 +84,14 @@ int main(int argc, char **argv) while (count < 100) { ret = ioctl(fd, MEDIA_IOC_DEVICE_INFO, &mdi); - if (ret < 0) + if (ret < 0) { printf("Media Device Info errno %s\n", strerror(errno)); - else - printf("Media device model %s driver %s\n", - mdi.model, mdi.driver); + break; + } + printf("Media device model %s driver %s\n", + mdi.model, mdi.driver); sleep(10); count++; } + close(fd); } -- 2.5.0