Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 19 Mar 2003 18:35:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 19 Mar 2003 18:35:35 -0500 Received: from 12-231-249-244.client.attbi.com ([12.231.249.244]:49418 "HELO kroah.com") by vger.kernel.org with SMTP id ; Wed, 19 Mar 2003 18:33:36 -0500 Date: Wed, 19 Mar 2003 15:32:19 -0800 From: Greg KH To: Oleg Drokin Cc: alan@redhat.com, linux-kernel@vger.kernel.org, david-b@pacbell.net Subject: Re: [2.4] Memleak in drivers/usb/hub.c::usb_reset_device Message-ID: <20030319233218.GA17620@kroah.com> References: <20030312194133.GA27968@linuxhacker.ru> <20030314193718.GC7560@kroah.com> <20030314200204.GC22018@linuxhacker.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030314200204.GC22018@linuxhacker.ru> User-Agent: Mutt/1.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 792 Lines: 20 On Fri, Mar 14, 2003 at 11:02:04PM +0300, Oleg Drokin wrote: > Hello! > > On Fri, Mar 14, 2003 at 11:37:19AM -0800, Greg KH wrote: > > > There seems to be a memleak in drivers/usb/hub.c::usb_reset_device() > > > on error exit path. See the patch. > > > Found with help of smatch + enhanced unfree script. > > And yes, as David said, there is another kind of error in this area for > > 2.5. Patches to clean that up would be appreciated. > > Ok, I guess something like that should work: I've applied this to my trees, thanks. greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/