Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755352AbcDEFY0 (ORCPT ); Tue, 5 Apr 2016 01:24:26 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:33673 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbcDEFYZ (ORCPT ); Tue, 5 Apr 2016 01:24:25 -0400 Subject: Re: [PATCH] perf config: Fix build with older toolchain. To: Vinson Lee , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Taeung Song , Jiri Olsa , Josh Poimboeuf , Alexei Starovoitov , Wang Nan References: <1459807659-9020-1-git-send-email-vlee@freedesktop.org> Cc: linux-kernel@vger.kernel.org From: Taeung Song Message-ID: <57034C03.2030603@gmail.com> Date: Tue, 5 Apr 2016 14:24:19 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1459807659-9020-1-git-send-email-vlee@freedesktop.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1608 Lines: 52 Hi, On 04/05/2016 07:07 AM, Vinson Lee wrote: > Fix build error on Ubuntu 12.04.5 with GCC 4.6.3. > > CC util/config.o > util/config.c: In function ‘perf_buildid_config’: > util/config.c:384:15: error: declaration of ‘dirname’ shadows a global declaration [-Werror=shadow] I'm sorry, lately I added perf_buildid_config() but I didn't test by gcc-4.6.3 > Fixes: 9cb5987c8227 ("perf config: Rework buildid_dir_command_config to perf_buildid_config") > Signed-off-by: Vinson Lee > --- > tools/perf/util/config.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c > index 5c20d783423b..a3d80a05e7a2 100644 > --- a/tools/perf/util/config.c > +++ b/tools/perf/util/config.c > @@ -381,11 +381,11 @@ static int perf_buildid_config(const char *var, const char *value) > { > /* same dir for all commands */ > if (!strcmp(var, "buildid.dir")) { > - const char *dirname = perf_config_dirname(var, value); > + const char *v = perf_config_dirname(var, value); Why you use 'v' variable name ? 'v' variable name was used in set_buildid_dir(), too. But I send a patch renaming 'v' to 'home' because 'home' is more readable. 37194f4 ("perf config: Rename 'v' to 'home' in set_buildid_dir()") https://lkml.org/lkml/2016/3/27/98 IMHO, I like using 'dir' instead of 'v'. Thanks, Taeung > > - if (!dirname) > + if (!v) > return -1; > - strncpy(buildid_dir, dirname, MAXPATHLEN-1); > + strncpy(buildid_dir, v, MAXPATHLEN-1); > buildid_dir[MAXPATHLEN-1] = '\0'; > } > >