Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932629AbcDEGDM (ORCPT ); Tue, 5 Apr 2016 02:03:12 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55560 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932529AbcDEGDJ (ORCPT ); Tue, 5 Apr 2016 02:03:09 -0400 Date: Tue, 5 Apr 2016 02:03:06 -0400 From: Greg Kroah-Hartman To: Sudeep Dutt Cc: linux-kernel@vger.kernel.org, Ashutosh Dixit , Fengguang Wu Subject: Re: [PATCH char-misc-linus] misc: mic: Fix randconfig build error Message-ID: <20160405060306.GA2814@kroah.com> References: <64ac4a1e3938ba5d3db01ac79d7bbc989f9001d3.1459745276.git.sudeep.dutt@intel.com> <20160405044104.GA28647@kroah.com> <1459832423.44796.4.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459832423.44796.4.camel@localhost> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1310 Lines: 37 On Mon, Apr 04, 2016 at 10:00:23PM -0700, Sudeep Dutt wrote: > On Mon, 2016-04-04 at 21:41 -0700, Greg Kroah-Hartman wrote: > > On Mon, Apr 04, 2016 at 09:32:30PM -0700, Sudeep Dutt wrote: > > > Fixes randconfig build error reported at > > > https://lkml.org/lkml/2016/4/3/135 by ensuring that > > > the VOP driver selects VIRTIO. > > > > > > Reported-by: Fengguang Wu > > > Reviewed-by: Ashutosh Dixit > > > Signed-off-by: Sudeep Dutt > > > --- > > > drivers/misc/mic/Kconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/misc/mic/Kconfig b/drivers/misc/mic/Kconfig > > > index 2e4f3ba..89e5917 100644 > > > --- a/drivers/misc/mic/Kconfig > > > +++ b/drivers/misc/mic/Kconfig > > > @@ -132,6 +132,7 @@ config VOP > > > tristate "VOP Driver" > > > depends on 64BIT && PCI && X86 && VOP_BUS > > > select VHOST_RING > > > + select VIRTIO > > > > Shouldn't it depend on this instead? > > Hi Greg, > > The documentation for "config VIRTIO" states that "This option is > selected by any driver which implements the virtio bus". I verified that > this patch fixes the build for the randconfig which was failing earlier. Ah, you are right, nevermind, I'll queue this up soon... thanks, greg k-h