From: "Li, Philip" <philip.li@intel.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
        "Wu, Fengguang" <fengguang.wu@intel.com>
CC: "kbuild-all@01.org" <kbuild-all@01.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Stephen Boyd <sboyd@codeaurora.org>
Subject: RE: drivers/base/power/opp/cpu.c:120:5: error: redefinition of
 'dev_pm_opp_set_sharing_cpus'
Thread-Topic: drivers/base/power/opp/cpu.c:120:5: error: redefinition of
 'dev_pm_opp_set_sharing_cpus'
Thread-Index: AQHRjujzDm0KOU7eJEq6ZIHVtCnPcZ96+HsQ
Date: Tue, 5 Apr 2016 07:18:20 +0000
Message-ID: <831EE4E5E37DCC428EB295A351E662491431DF0C@shsmsx102.ccr.corp.intel.com>
References: <201604050956.VU7awDfC%fengguang.wu@intel.com>
 <20160405031001.GD20655@vireshk-i7>
In-Reply-To: <20160405031001.GD20655@vireshk-i7>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2709
Lines: 72


> -----Original Message-----
> From: Viresh Kumar [mailto:viresh.kumar@linaro.org]
> Sent: Tuesday, April 5, 2016 11:10 AM
> To: Wu, Fengguang <fengguang.wu@intel.com>
> Cc: kbuild-all@01.org; linux-kernel@vger.kernel.org; Rafael J. Wysocki
> <rjw@rjwysocki.net>; Stephen Boyd <sboyd@codeaurora.org>
> Subject: Re: drivers/base/power/opp/cpu.c:120:5: error: redefinition of
> 'dev_pm_opp_set_sharing_cpus'
> 
> On 05-04-16, 09:34, kbuild test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> > head:   9735a22799b9214d17d3c231fe377fc852f042e9
> > commit: f59d3ee8480d30f41914cb4bed5086237e8507b0 PM / OPP: Move
> cpu specific code to opp/cpu.c
> > date:   7 months ago
> > config: i386-randconfig-c0-04050854 (attached as .config)
> > reproduce:
> >         git checkout f59d3ee8480d30f41914cb4bed5086237e8507b0
> >         # save the attached .config to linux build tree
> >         make ARCH=i386
> 
> Something isn't right in your setup. This is a 7 months old patch you have
> reported now and I can see no problem with the patch as well.
Thanks, Viresh, will check why old commit is reported. On the other hand, I think even one config is not set, it should not introduce build error, which seems a valid failure. 

> 
> Over that, the attached .config doesn't have CONFIG_PM_OPP enabled, so
> below can't really compile.
> 
> > All errors (new ones prefixed by >>):
> >
> > >> drivers/base/power/opp/cpu.c:120:5: error: redefinition of
> 'dev_pm_opp_set_sharing_cpus'
> >     int dev_pm_opp_set_sharing_cpus(struct device *cpu_dev,
> cpumask_var_t cpumask)
> >         ^
> >    In file included from drivers/base/power/opp/opp.h:20:0,
> >                     from drivers/base/power/opp/cpu.c:21:
> >    include/linux/pm_opp.h:165:19: note: previous definition of
> 'dev_pm_opp_set_sharing_cpus' was here
> >     static inline int dev_pm_opp_set_sharing_cpus(struct device *cpu_dev,
> cpumask_var_t cpumask)
> >                       ^
> >
> > vim +/dev_pm_opp_set_sharing_cpus +120 drivers/base/power/opp/cpu.c
> >
> >    114		*table = NULL;
> >    115	}
> >    116	EXPORT_SYMBOL_GPL(dev_pm_opp_free_cpufreq_table);
> >    117	#endif	/* CONFIG_CPU_FREQ */
> >    118
> >    119	/* Required only for V1 bindings, as v2 can manage it from DT
> itself */
> >  > 120	int dev_pm_opp_set_sharing_cpus(struct device *cpu_dev,
> cpumask_var_t cpumask)
> >    121	{
> >    122		struct device_list_opp *list_dev;
> >    123		struct device_opp *dev_opp;
> >
> > ---
> > 0-DAY kernel test infrastructure                Open Source Technology
> Center
> > https://lists.01.org/pipermail/kbuild-all                   Intel
> Corporation
> 
> 
> 
> --
> viresh