Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757305AbcDEHeL (ORCPT ); Tue, 5 Apr 2016 03:34:11 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:47367 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbcDEHeH (ORCPT ); Tue, 5 Apr 2016 03:34:07 -0400 Subject: Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support To: , , , , , , , , , , , , , , , , , , References: <1459502492-19891-1-git-send-email-oulijun@huawei.com> <1459502492-19891-3-git-send-email-oulijun@huawei.com> <20160402015830.GD8565@leon.nu> From: oulijun Message-ID: <57036A25.9000106@huawei.com> Date: Tue, 5 Apr 2016 15:32:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160402015830.GD8565@leon.nu> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.61.25.147] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.57036A39.009A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: dd5efc29daeacd8f4fc9526dc18a8035 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3211 Lines: 68 Hi, Leon Romanovsky On 2016/4/2 9:58, Leon Romanovsky wrote: > On Fri, Apr 01, 2016 at 05:21:31PM +0800, Lijun Ou wrote: >> The driver for HiSilicon RoCE is a platform driver. >> The driver will support multiple versions of hardware. Currently only "v1" >> for hip06 SoC is supported. >> The driver includes two parts: common driver and hardware-specific >> operations. hns_roce_v1_hw.c and hns_roce_v1_hw.h are files for >> hardware-specific operations only for v1 engine, and other files(.c and .h) >> for common algorithm and common hardware operations. >> >> Signed-off-by: Lijun Ou >> Signed-off-by: Wei Hu(Xavier) >> Signed-off-by: Znlong >> --- >> MAINTAINERS | 8 + >> drivers/infiniband/Kconfig | 1 + >> drivers/infiniband/hw/Makefile | 1 + >> drivers/infiniband/hw/hisilicon/hns/Kconfig | 10 + >> drivers/infiniband/hw/hisilicon/hns/Makefile | 9 + >> drivers/infiniband/hw/hisilicon/hns/hns_roce_ah.c | 110 + > > We are not adding name of company (hisilicon) for infiniband HW drivers > drivers/infiniband/hw/hisilicon/hns/hns_roce_ah.c > ---> > drivers/infiniband/hw/hns/hns_roce_ah.c > Surely, i will modify the location of RoCE driver code after disscussed in next patch > >> .../infiniband/hw/hisilicon/hns/hns_roce_alloc.c | 239 ++ > ^^^^^^ > Please fix you paths. > >> drivers/infiniband/hw/hisilicon/hns/hns_roce_cmd.c | 338 +++ >> drivers/infiniband/hw/hisilicon/hns/hns_roce_cmd.h | 80 + >> .../infiniband/hw/hisilicon/hns/hns_roce_common.h | 308 +++ >> drivers/infiniband/hw/hisilicon/hns/hns_roce_cq.c | 436 +++ >> .../infiniband/hw/hisilicon/hns/hns_roce_device.h | 794 ++++++ >> drivers/infiniband/hw/hisilicon/hns/hns_roce_eq.c | 758 ++++++ >> drivers/infiniband/hw/hisilicon/hns/hns_roce_eq.h | 132 + >> drivers/infiniband/hw/hisilicon/hns/hns_roce_icm.c | 578 ++++ >> drivers/infiniband/hw/hisilicon/hns/hns_roce_icm.h | 112 + >> .../infiniband/hw/hisilicon/hns/hns_roce_main.c | 1097 ++++++++ >> drivers/infiniband/hw/hisilicon/hns/hns_roce_mr.c | 605 +++++ >> drivers/infiniband/hw/hisilicon/hns/hns_roce_pd.c | 124 + >> drivers/infiniband/hw/hisilicon/hns/hns_roce_qp.c | 841 ++++++ >> .../infiniband/hw/hisilicon/hns/hns_roce_user.h | 31 + >> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c | 2832 ++++++++++++++++++++ >> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.h | 985 +++++++ > ^^^^^^ > Do you support v1 of RoCE or v1 of your HW? > Here, v1 stands for hw, that is, we support v1 of our hw. >> 23 files changed, 10429 insertions(+) > > Please appreciate the effort needed to review such large patch and > invest time and effort to divide this to number of small easy review patches. > Surely, i have pay attention to the patch, but i consider that it is not better to split the patch into small patch. because it will the base function of RoCE. For your advice, i will make further efforts to taking a discussion how to reslove the question. thanks Lijun Ou > . >