Date: Tue, 5 Apr 2016 10:11:07 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Juergen Gross <jgross@suse.com>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
        boris.ostrovsky@oracle.com, david.vrabel@citrix.com, mingo@redhat.com,
        Douglas_Warzecha@dell.com, pali.rohar@gmail.com, jdelvare@suse.com,
        linux@roeck-us.net, tglx@linutronix.de, hpa@zytor.com, jeremy@goop.org,
        chrisw@sous-sol.org, akataria@vmware.com, rusty@rustcorp.com.au,
        virtualization@lists.linux-foundation.org, x86@kernel.org
Subject: Re: [PATCH v4 3/6] smp: add function to execute a function
 synchronously on a cpu
Message-ID: <20160405081107.GH3448@twins.programming.kicks-ass.net>
References: <1459833007-11618-1-git-send-email-jgross@suse.com>
 <1459833007-11618-4-git-send-email-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1459833007-11618-4-git-send-email-jgross@suse.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 932
Lines: 35

On Tue, Apr 05, 2016 at 07:10:04AM +0200, Juergen Gross wrote:
> +int smp_call_on_cpu(unsigned int cpu, bool pin, int (*func)(void *), void *par)

Why .pin and not .phys? .pin does not (to me) reflect the
hypervisor/physical-cpu thing.

Also, as per smp_call_function_single() would it not be more consistent
to make this the last argument?

> +{
> +	struct smp_call_on_cpu_struct sscs = {
> +		.work = __WORK_INITIALIZER(sscs.work, smp_call_on_cpu_callback),
> +		.done = COMPLETION_INITIALIZER_ONSTACK(sscs.done),
> +		.func = func,
> +		.data = par,
> +		.cpu  = pin ? cpu : -1,
> +	};
> +
> +	if (cpu >= nr_cpu_ids)

You might want to also include cpu_online().

	if (cpu >= nr_cpu_ids || !cpu_online(cpu))
> +		return -ENXIO;

Seeing how its fairly hard to schedule work on a cpu that's not actually
there.

> +
> +	queue_work_on(cpu, system_wq, &sscs.work);
> +	wait_for_completion(&sscs.done);
> +
> +	return sscs.ret;
> +}