Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757954AbcDEJm0 (ORCPT ); Tue, 5 Apr 2016 05:42:26 -0400 Received: from mga01.intel.com ([192.55.52.88]:49982 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751368AbcDEJmY (ORCPT ); Tue, 5 Apr 2016 05:42:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,443,1455004800"; d="scan'208";a="681032219" Date: Tue, 5 Apr 2016 12:42:21 +0300 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: Peter Huewe , Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH] tpm: remove redundant code from self-test functions Message-ID: <20160405094221.GA12672@intel.com> References: <1459344045-21602-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20160331054623.GB20504@obsidianresearch.com> <20160331063756.GA6393@intel.com> <20160402031615.GA28449@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160402031615.GA28449@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 970 Lines: 24 On Fri, Apr 01, 2016 at 09:16:15PM -0600, Jason Gunthorpe wrote: > On Thu, Mar 31, 2016 at 09:37:56AM +0300, Jarkko Sakkinen wrote: > > On Wed, Mar 30, 2016 at 11:46:23PM -0600, Jason Gunthorpe wrote: > > > On Wed, Mar 30, 2016 at 04:20:45PM +0300, Jarkko Sakkinen wrote: > > > > > > > - rc = be32_to_cpu(cmd.header.out.return_code); > > > > if (rc == TPM_ERR_DISABLED || rc == TPM_ERR_DEACTIVATED) { > > > > > > This line is the entire reason it is open coded, I see it being > > > removed, but I don't see how the functionality is maintained? > > > > When tpm_trance_cmd() returns a positive number it is the TPM error code > > that it returns. tpm_pcr_read() does pass through whatever > > tpm_trace_cmd() returns so the above condition should still work as > > expected. > > Okay, everything looks fine to me I applied this to http://git.infradead.org/users/jjs/linux-tpmdd.git in order to get exposure (tested-by's are always welcome). > Jason /Jarkko