Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757568AbcDEJsR (ORCPT ); Tue, 5 Apr 2016 05:48:17 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:37402 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756613AbcDEJsP (ORCPT ); Tue, 5 Apr 2016 05:48:15 -0400 Date: Tue, 5 Apr 2016 10:48:12 +0100 From: Matt Fleming To: deckard Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, joeyli , "Kweh, Hock Leong" , Ard Biesheuvel , Borislav Petkov , Andy Lutomirski , Sam Protsenko , Peter Jones , Greg Kroah-Hartman Subject: Re: [PATCH 4/4] efi: A misc char interface to update EFI firmware Message-ID: <20160405094812.GA2701@codeblueprint.co.uk> References: <1458219431-24741-1-git-send-email-matt@codeblueprint.co.uk> <1458219431-24741-5-git-send-email-matt@codeblueprint.co.uk> <1459478930.6099.249.camel@nexus-software.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459478930.6099.249.camel@nexus-software.ie> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 952 Lines: 23 On Fri, 01 Apr, at 03:48:50AM, Bryan O'Donoghue wrote: > On Thu, 2016-03-17 at 12:57 +0000, Matt Fleming wrote: > > Tested with Intel Quark Galileo GEN1 platform. > > + * If the capsule is successfully submitted to the firmware, any > + * subsequent calls to efi_capsule_pending() will return true. @pages > + * must not be released or modified if this function returns > + * successfully. > > The only minor nit here is that you can't actually test this on a > Galileo GEN1 since there's a non-standard header required to update the > firmware on that platform ! > > So I suggest dropping that particular comment in the git log, since you > can't actually *do* that on a Galileo without doing something about the > required CSH (Clanton Secure Header) prefixed to the standard Capsule > header. > > Otherwise. > > Reviewed-by: Bryan O'Donoghue Thanks Bryan. I've updated the commit log and added your Reviewed-by.