Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757634AbcDEKV6 (ORCPT ); Tue, 5 Apr 2016 06:21:58 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:41060 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757404AbcDEKV4 (ORCPT ); Tue, 5 Apr 2016 06:21:56 -0400 Subject: Re: [PATCH 3/8] mfd: twl-core: Rename TWL4030_CORE Kconfig option to TWL_CORE To: Paul Kocialkowski , , , , , Lee Jones References: <1459279341-17389-1-git-send-email-contact@paulk.fr> <1459279341-17389-3-git-send-email-contact@paulk.fr> <56FBF1FD.8090903@ti.com> <1459627935.12073.35.camel@paulk.fr> CC: Rob Herring , Tony Lindgren , Dmitry Torokhov , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse From: Grygorii Strashko Message-ID: <5703919E.3020707@ti.com> Date: Tue, 5 Apr 2016 13:21:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1459627935.12073.35.camel@paulk.fr> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2473 Lines: 74 On 04/02/2016 11:12 PM, Paul Kocialkowski wrote: > Le mercredi 30 mars 2016 à 18:34 +0300, Grygorii Strashko a écrit : >> On 03/29/2016 10:22 PM, Paul Kocialkowski wrote: >>> >>> Since the twl-core mfd driver is not limited to twl4030 support, but also >>> supports other chips of the TWL family, it makes sense to rename its >>> matching >>> Kconfig opton to a non-model-specific name. >> >> Personally I don't see too much reason for this, but it's up to maintainers to >> decide. > > I'm a strong advocate of consistency in naming and using twl4030 prefixes for > drivers that are common to more twl chips looks very inconsistent to me. > Besides, some common twl drivers are already using the twl prefix, so this can > also be seen as harmonisation. Yah. May be. But I see the problem with your series - small amount of functional changes is hidden in the fog of huge amount of renaming/beautification ;) But, again, this is my personal opinion - final decision is up to maintainers + cc: Lee Jones > >> Regarding this patch - pls, do not mix Kconfig and code changes. > > Do you mean that for code changes that are directly affected by Kconfig changes > (e.g. #ifdef CONFIG_)? Is the policy that "each commit must produce a working > result" or is it okay to break drivers in between commits of the same series? I mean this: */ -#define TWL4030_CORE_NR_IRQS 8 +#define TWL_CORE_NR_IRQS 8 #define TWL4030_PWR_NR_IRQS 8 /* PIH register offsets */ @@ -693,7 +693,7 @@ int twl4030_init_irq(struct device *dev, int irq_num) * the hwirqs numbers are defined contiguously from 1 to 15. * Create only one domain for both. */ - nr_irqs = TWL4030_PWR_NR_IRQS + TWL4030_CORE_NR_IRQS; + nr_irqs = TWL4030_PWR_NR_IRQS + TWL_CORE_NR_IRQS; irq_base = irq_alloc_descs(-1, 0, nr_irqs, 0); if (IS_ERR_VALUE(irq_base)) { @@ -704,7 +704,7 @@ int twl4030_init_irq(struct device *dev, int irq_num) irq_domain_add_legacy(node, nr_irqs, irq_base, 0, &irq_domain_simple_ops, NULL); - irq_end = irq_base + TWL4030_CORE_NR_IRQS; + irq_end = irq_base + TWL_CORE_NR_IRQS; > >> And it will be good to have cover letter. > > Noted, I'll come up with something for v2. > >>> Signed-off-by: Paul Kocialkowski >>> --- >>> arch/arm/mach-omap2/Kconfig | 2 +- >>> arch/arm/mach-omap2/Makefile | 2 +- >>> arch/arm/mach-omap2/pm.h | 2 +- >>> arch/arm/plat-omap/Kconfig | 2 +- [..] -- regards, -grygorii