Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757865AbcDELch (ORCPT ); Tue, 5 Apr 2016 07:32:37 -0400 Received: from casper.infradead.org ([85.118.1.10]:60826 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756369AbcDELcg (ORCPT ); Tue, 5 Apr 2016 07:32:36 -0400 Date: Tue, 5 Apr 2016 13:32:33 +0200 From: Peter Zijlstra To: xlpang@redhat.com Cc: linux-kernel@vger.kernel.org, Juri Lelli , Ingo Molnar , Steven Rostedt , Thomas Gleixner Subject: Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline tasks Message-ID: <20160405113233.GL3448@twins.programming.kicks-ass.net> References: <1459508418-25577-1-git-send-email-xlpang@redhat.com> <20160401113827.GQ3430@twins.programming.kicks-ass.net> <56FE685E.6080001@redhat.com> <19912883-8AB1-4DFD-A0E1-F23057785243@infradead.org> <56FE78E0.5060504@redhat.com> <20160401215143.GB2906@worktop> <57037974.1020002@redhat.com> <20160405091954.GI3448@twins.programming.kicks-ass.net> <20160405092954.GC24771@twins.programming.kicks-ass.net> <57039806.2070102@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57039806.2070102@redhat.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 505 Lines: 15 On Tue, Apr 05, 2016 at 06:48:38PM +0800, Xunlei Pang wrote: > This is cool, I think we should also init "pi_task" properly for INIT_MUTEX and fork, > otherwise looks good to me :-) Indeed.. > Besides, do you think we can kill "pi_waiters_leftmost" from task_struct, as we > can easily get it from "pi_waiters"? I don't quickly see a way to do that, different locking rules govern the two.. which was the whole problem we started with :/ > I will test it further with these new changes soon. Thanks!