Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758644AbcDEMtH (ORCPT ); Tue, 5 Apr 2016 08:49:07 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:43202 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755536AbcDEMtE (ORCPT ); Tue, 5 Apr 2016 08:49:04 -0400 Date: Tue, 5 Apr 2016 05:49:02 -0700 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig , Boaz Harrosh , Kent Overstreet , Shaohua Li , "open list:BCACHE (BLOCK LAYER CACHE)" , "open list:SOFTWARE RAID (Multiple Disks) SUPPORT" Subject: Re: [PATCH 11/27] bcache: io.c: use bio_set_vec_table Message-ID: <20160405124902.GA11986@infradead.org> References: <1459857443-20611-1-git-send-email-tom.leiming@gmail.com> <1459857443-20611-12-git-send-email-tom.leiming@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459857443-20611-12-git-send-email-tom.leiming@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 795 Lines: 18 On Tue, Apr 05, 2016 at 07:56:56PM +0800, Ming Lei wrote: > diff --git a/drivers/md/bcache/io.c b/drivers/md/bcache/io.c > index 86a0bb8..1c48462 100644 > --- a/drivers/md/bcache/io.c > +++ b/drivers/md/bcache/io.c > @@ -26,8 +26,7 @@ struct bio *bch_bbio_alloc(struct cache_set *c) > > bio_init(bio); > bio->bi_flags |= BIO_POOL_NONE << BIO_POOL_OFFSET; > - bio->bi_max_vecs = bucket_pages(c); > - bio->bi_io_vec = bio->bi_inline_vecs; > + bio_set_vec_table(bio, bio->bi_inline_vecs, bucket_pages(c)); All this bcache code needs to move away from bio_init on a bio embedded in a driver private structure toward properly using bio_alloc / bio_alloc_bioset. That will also fix the crash with bcache over md that Shaohua reported, so I'd suggest to fast track this part of the series.