Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758684AbcDEM7D (ORCPT ); Tue, 5 Apr 2016 08:59:03 -0400 Received: from casper.infradead.org ([85.118.1.10]:35045 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754520AbcDEM7B (ORCPT ); Tue, 5 Apr 2016 08:59:01 -0400 Date: Tue, 5 Apr 2016 14:58:59 +0200 From: Peter Zijlstra To: Luca Abeni Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Juri Lelli Subject: Re: [RFC v2 4/7] Fix the update of the total -deadline utilization Message-ID: <20160405125859.GY3430@twins.programming.kicks-ass.net> References: <1459523553-29089-1-git-send-email-luca.abeni@unitn.it> <1459523553-29089-5-git-send-email-luca.abeni@unitn.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459523553-29089-5-git-send-email-luca.abeni@unitn.it> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 599 Lines: 16 On Fri, Apr 01, 2016 at 05:12:30PM +0200, Luca Abeni wrote: > + /* > + * XXX this is slightly incorrect: when the task > + * utilization decreases, we should delay the total > + * utilization change until the task's 0-lag point. > + * But this would require to set the task's "inactive > + * timer" when the task is not inactive. > + */ Could you quickly remind me why this is a problem? The timeline does continue running right? So even if the task isn't active now, it will still reach its 0-lag point. > __dl_clear(dl_b, p->dl.dl_bw); > __dl_add(dl_b, new_bw); > err = 0;