Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 19 Mar 2003 21:27:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 19 Mar 2003 21:27:45 -0500 Received: from ns.suse.de ([213.95.15.193]:28428 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id ; Wed, 19 Mar 2003 21:27:44 -0500 Date: Thu, 20 Mar 2003 03:38:43 +0100 From: Andi Kleen To: Arnd Bergmann Cc: Andi Kleen , Pavel Machek , linux-kernel@vger.kernel.org Subject: Re: share COMPATIBLE_IOCTL()s across architectures Message-ID: <20030320023843.GA22795@wotan.suse.de> References: <20030320001013$67af@gated-at.bofh.it> <20030320001013$68b4@gated-at.bofh.it> <200303200136.h2K1aDsD001827@post.webmailer.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200303200136.h2K1aDsD001827@post.webmailer.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 832 Lines: 17 On Thu, Mar 20, 2003 at 02:35:30AM +0100, Arnd Bergmann wrote: > Why not simply move the common COMPATIBLE_IOCTLs and includes into > kernel/compat_ioctl.c or similar? That would IMHO be cleaner and > it does not need more preprocessing hacks. > There can still be a second init_sys32_ioctl() copy to handle the arch > specific list with additional translations. This would work for COMPATIBLE_IOCTLS, but the conversions handlers would need a new asm/ file for the macros. They're declared with assembler magic to avoid declaring all the functions. This way you need less files. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/