Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758874AbcDEN0R (ORCPT ); Tue, 5 Apr 2016 09:26:17 -0400 Received: from www.linutronix.de ([62.245.132.108]:38229 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758580AbcDEN0P (ORCPT ); Tue, 5 Apr 2016 09:26:15 -0400 Date: Tue, 5 Apr 2016 15:26:11 +0200 (CEST) From: Anna-Maria Gleixner To: Ralf Baechle cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, rt@linutronix.de Subject: Re: [PREEMPT-RT] [PATCH] MIPS: Remove no longer needed work_on_cpu() call In-Reply-To: <20160404150332.GD15222@linux-mips.org> Message-ID: References: <1459772283-40657-1-git-send-email-anna-maria@linutronix.de> <20160404150332.GD15222@linux-mips.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1109 Lines: 29 On Mon, 4 Apr 2016, Ralf Baechle wrote: > On Mon, Apr 04, 2016 at 02:18:03PM +0200, Anna-Maria Gleixner wrote: > > > Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to > > hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and > > CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this > > work_on_cpu() calls are no longer required. > > > > Replace work_on_cpu() with a direct call of mips_cdmm_bus_up() or > > mips_cdmm_bus_down(). Description of those functions are adapted. > > > > Cc: Ralf Baechle > > Cc: linux-mips@linux-mips.org > > Signed-off-by: Anna-Maria Gleixner > > --- > > drivers/bus/mips_cdmm.c | 12 +++++++----- > > 1 file changed, 7 insertions(+), 5 deletions(-) > > Thanks, queued for 4.7. > Please do not queue it. Heiko Carstens pointed out a problem: It isn't ensured, that the callbacks of CPU_DOWN_FAILED are always processed on the CPU that failed in CPU_DOWN_PREPARE (see http://marc.info/?l=linux-s390&m=145985621421250&w=2 ). Once this issue is fixed, I will resend the patch. Anna-Maria