Date: Tue, 5 Apr 2016 10:38:19 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Taeung Song <taeung.dev@gmail.com>
Cc: Vinson Lee <vlee@freedesktop.org>, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Taeung Song <treeze.taeung@gmail.com>, Jiri Olsa <jolsa@kernel.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Wang Nan <wangnan0@huawei.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf config: Fix build with older toolchain.
Message-ID: <20160405133819.GB5945@kernel.org>
References: <1459807659-9020-1-git-send-email-vlee@freedesktop.org>
 <57034C03.2030603@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <57034C03.2030603@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 723
Lines: 19

Em Tue, Apr 05, 2016 at 02:24:19PM +0900, Taeung Song escreveu:
> On 04/05/2016 07:07 AM, Vinson Lee wrote:
> >  	if (!strcmp(var, "buildid.dir")) {
> >-		const char *dirname = perf_config_dirname(var, value);
> >+		const char *v = perf_config_dirname(var, value);
> 
> Why you use 'v' variable name ?
> 
> 'v' variable name was used in set_buildid_dir(), too.
> But I send a patch renaming 'v' to 'home' because 'home' is more readable.
> 37194f4 ("perf config: Rename 'v' to 'home' in set_buildid_dir()")
> https://lkml.org/lkml/2016/3/27/98
> 
> IMHO, I like using 'dir' instead of 'v'.

Whatever, I'm switching this to 'dir', but don't pay _that_ much
attention to variables that have such a narrow scope...

- Arnaldo