Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759161AbcDENvK (ORCPT ); Tue, 5 Apr 2016 09:51:10 -0400 Received: from dougal.metanate.com ([90.155.101.14]:45354 "EHLO metanate.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759118AbcDENvE (ORCPT ); Tue, 5 Apr 2016 09:51:04 -0400 From: John Keeping To: Mark Yao Cc: John Keeping , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] drm/rockchip: remove redundant statement Date: Tue, 5 Apr 2016 14:50:31 +0100 Message-Id: <1459864232-25033-1-git-send-email-john@metanate.com> X-Mailer: git-send-email 2.8.0.rc4.238.g874082a Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 829 Lines: 22 The call to arm_iommu_detach_device() on the previous line sets dev->archdata.mapping to NULL so this call is always a no-op. Signed-off-by: John Keeping --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c index f556a8f..7695c79 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c @@ -244,7 +244,6 @@ static int rockchip_drm_unload(struct drm_device *drm_dev) drm_kms_helper_poll_fini(drm_dev); component_unbind_all(dev, drm_dev); arm_iommu_detach_device(dev); - arm_iommu_release_mapping(dev->archdata.mapping); drm_mode_config_cleanup(drm_dev); drm_dev->dev_private = NULL; -- 2.8.0.rc4.238.g874082a