Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758314AbcDEQrs (ORCPT ); Tue, 5 Apr 2016 12:47:48 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34781 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932914AbcDEQrp (ORCPT ); Tue, 5 Apr 2016 12:47:45 -0400 Date: Tue, 5 Apr 2016 18:47:29 +0200 From: luca abeni To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Juri Lelli Subject: Re: [RFC v2 1/7] Track the active utilisation Message-ID: <20160405184729.5a4b209a@utopia> In-Reply-To: <20160405122327.GU3430@twins.programming.kicks-ass.net> References: <1459523553-29089-1-git-send-email-luca.abeni@unitn.it> <1459523553-29089-2-git-send-email-luca.abeni@unitn.it> <20160405122327.GU3430@twins.programming.kicks-ass.net> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 757 Lines: 29 Hi Peter, first of all, thanks for all the reviews! On Tue, 5 Apr 2016 14:23:27 +0200 Peter Zijlstra wrote: [...] > > @@ -1218,6 +1242,9 @@ static void task_dead_dl(struct task_struct *p) > > /* XXX we should retain the bw until 0-lag */ > > dl_b->total_bw -= p->dl.dl_bw; > > raw_spin_unlock_irq(&dl_b->lock); > > + > > + if (task_on_rq_queued(p)) > > + sub_running_bw(&p->dl, &rq->dl); > > } > > > > A dead task cannot be running, not be queued, right? ISTR you remove > this hunk in a later patch as well. I suspect this is some "better safe than sorry" code I added trying to solve some issue that then I solved in a different way... But I forgot to remove it. I'll fix the patch and re-test. Thanks, Luca