Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759086AbcDERJw (ORCPT ); Tue, 5 Apr 2016 13:09:52 -0400 Received: from down.free-electrons.com ([37.187.137.238]:44977 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758212AbcDERJu (ORCPT ); Tue, 5 Apr 2016 13:09:50 -0400 Date: Tue, 5 Apr 2016 19:09:42 +0200 From: Boris Brezillon To: Laxman Dewangan Cc: , , , , , , , Subject: Re: [PATCH 05/20] mfd: atmel-hlcdc: Use devm_mfd_add_devices() for mfd_device registration Message-ID: <20160405190942.66cbb368@bbrezillon> In-Reply-To: <1459856912-17859-6-git-send-email-ldewangan@nvidia.com> References: <1459856912-17859-1-git-send-email-ldewangan@nvidia.com> <1459856912-17859-6-git-send-email-ldewangan@nvidia.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1687 Lines: 55 On Tue, 5 Apr 2016 17:18:17 +0530 Laxman Dewangan wrote: > Use devm_mfd_add_devices() for mfd devices registration and get > rid of .remove callback to remove mfd devices. This is done > by managed device framework. > > Signed-off-by: Laxman Dewangan > CC: Boris Brezillon Acked-by: Boris Brezillon > --- > drivers/mfd/atmel-hlcdc.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/drivers/mfd/atmel-hlcdc.c b/drivers/mfd/atmel-hlcdc.c > index 06c2058..653bf261 100644 > --- a/drivers/mfd/atmel-hlcdc.c > +++ b/drivers/mfd/atmel-hlcdc.c > @@ -128,18 +128,11 @@ static int atmel_hlcdc_probe(struct platform_device *pdev) > > dev_set_drvdata(dev, hlcdc); > > - return mfd_add_devices(dev, -1, atmel_hlcdc_cells, > + return devm_mfd_add_devices(dev, -1, atmel_hlcdc_cells, > ARRAY_SIZE(atmel_hlcdc_cells), > NULL, 0, NULL); > } > > -static int atmel_hlcdc_remove(struct platform_device *pdev) > -{ > - mfd_remove_devices(&pdev->dev); > - > - return 0; > -} > - > static const struct of_device_id atmel_hlcdc_match[] = { > { .compatible = "atmel,at91sam9n12-hlcdc" }, > { .compatible = "atmel,at91sam9x5-hlcdc" }, > @@ -152,7 +145,6 @@ MODULE_DEVICE_TABLE(of, atmel_hlcdc_match); > > static struct platform_driver atmel_hlcdc_driver = { > .probe = atmel_hlcdc_probe, > - .remove = atmel_hlcdc_remove, > .driver = { > .name = "atmel-hlcdc", > .of_match_table = atmel_hlcdc_match, -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com