Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759148AbcDERRu (ORCPT ); Tue, 5 Apr 2016 13:17:50 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:36771 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759010AbcDERRs (ORCPT ); Tue, 5 Apr 2016 13:17:48 -0400 Date: Tue, 5 Apr 2016 19:17:39 +0200 From: luca abeni To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Juri Lelli Subject: Re: [RFC v2 3/7] Improve the tracking of active utilisation Message-ID: <20160405191739.44398c77@utopia> In-Reply-To: <20160405144803.GZ3430@twins.programming.kicks-ass.net> References: <1459523553-29089-1-git-send-email-luca.abeni@unitn.it> <1459523553-29089-4-git-send-email-luca.abeni@unitn.it> <20160405144803.GZ3430@twins.programming.kicks-ass.net> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 691 Lines: 22 On Tue, 5 Apr 2016 16:48:03 +0200 Peter Zijlstra wrote: > On Fri, Apr 01, 2016 at 05:12:29PM +0200, Luca Abeni wrote: > > + /* > > + * We cannot use inactive_task_timer() to invoke sub_running_bw() > > + * at the 0-lag time, because the task could have been migrated > > + * while SCHED_OTHER in the meanwhile. > > + */ > > + if (hrtimer_active(&p->dl.inactive_timer) && > > + !hrtimer_callback_running(&p->dl.inactive_timer)) > > sub_running_bw(&p->dl, &rq->dl); > > hrtimer_is_queued() ? Uhm... I do not remember why I used this condition, but hrtimer_is_queued() should be the right thing to be used, yes... I'll update the patch. Thanks, Luca