Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752957AbcDERu0 (ORCPT ); Tue, 5 Apr 2016 13:50:26 -0400 Received: from mail-ig0-f194.google.com ([209.85.213.194]:36822 "EHLO mail-ig0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbcDERuZ (ORCPT ); Tue, 5 Apr 2016 13:50:25 -0400 MIME-Version: 1.0 In-Reply-To: References: <1459867006-19605-1-git-send-email-bastienphilbert@gmail.com> Date: Tue, 5 Apr 2016 13:50:24 -0400 Message-ID: Subject: Re: [PATCH] bnx2fc: Fix locking requirements in bnx2fc_init_tgt From: Bastien Bastien Philbert To: Chad Dupuis Cc: QLogic-Storage-Upstream@qlogic.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1501 Lines: 42 On Tue, Apr 5, 2016 at 1:43 PM, Chad Dupuis wrote: > > > On Tue, 5 Apr 2016, Bastien Philbert wrote: > >> This fixes the locking around the call to bnx2fc_alloc_id to comply >> with the comments about this particular function's definition about >> requiring the need to hold the hba mutex before and after calling >> it. >> Signed-off-by: Bastien Philbert >> --- >> drivers/scsi/bnx2fc/bnx2fc_tgt.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/scsi/bnx2fc/bnx2fc_tgt.c >> b/drivers/scsi/bnx2fc/bnx2fc_tgt.c >> index 08ec318..f2988cd 100644 >> --- a/drivers/scsi/bnx2fc/bnx2fc_tgt.c >> +++ b/drivers/scsi/bnx2fc/bnx2fc_tgt.c >> @@ -368,9 +368,13 @@ static int bnx2fc_init_tgt(struct bnx2fc_rport *tgt, >> return -1; >> } >> >> + mutex_lock(&hba->hba_mutex); >> tgt->fcoe_conn_id = bnx2fc_alloc_conn_id(hba, tgt); >> - if (tgt->fcoe_conn_id == -1) >> + if (tgt->fcoe_conn_id == -1) { >> + mutex_unlock(&hba->hba_mutex); >> return -1; >> + } >> + mutex_unlock(&hba->hba_mutex); >> >> BNX2FC_TGT_DBG(tgt, "init_tgt - conn_id = 0x%x\n", >> tgt->fcoe_conn_id); >> >> > > Taking the mutex here is not needed as it is already taken in > bnx2fc_rport_event_handler() in the call chain > bnx2fc_rport_event_handler->bnx2fc_offload_session->bnx2fc_init_tgt->bnx2fc_alloc_conn_id Ok thanks and good to known. Bastien