Date: Tue, 5 Apr 2016 13:37:49 -0500
From: Dinh Nguyen <dinguyen@opensource.altera.com>
To: Borislav Petkov <bp@alien8.de>
CC: Thor Thayer <tthayer@opensource.altera.com>, <dougthompson@xmission.com>,
        <m.chehab@samsung.com>, <robh+dt@kernel.org>, <pawel.moll@arm.com>,
        <mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
        <galak@codeaurora.org>, <linux@arm.linux.org.uk>,
        <grant.likely@linaro.org>, <devicetree@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, <linux-edac@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCHv2 6/7] ARM: socfpga: Enable Arria10 OCRAM ECC on
 startup
In-Reply-To: <20160405053110.GA17541@pd.tnic>
Message-ID: <alpine.DEB.2.02.1604051333070.32718@linux-builds1>
References: <1459450087-24792-1-git-send-email-tthayer@opensource.altera.com> <1459450087-24792-7-git-send-email-tthayer@opensource.altera.com> <57034C4D.9010204@opensource.altera.com> <20160405053110.GA17541@pd.tnic>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1373;2:zPvw51+uGkZ16lPeErzbcy8/xYeun8sV+t0iR5GE2VSwpDEJ6y9v7z1KmEcS+MXnHUVoU2q6hvPS5OonBTCzvoZZWQ6+Z9HExmB6p4TFoPyrL68E35c0rBGqCtgLrnNaurMcvPwHVMOmvqsr1BfWFWyjumeDDmvHzSlF7m/X9f6I1GUJvT+ds7tIANX+y12j;3:cIfSMeRam+KtcxMJ62xvSYlLqOsbO3rhEowblFvlXkuq0E7bLLpngpjYak9yLFbCd8h8Zk+Oy7kWGMFMEr8tWlo6FmLIB4VwnYgjNZx+7mIjL9peFqOpmtSvfV0xoTr5;25:0/LQodeH29wpSM410yYmm3zdGBk8fN/fZ4WmLp/sXTWvvpQwqcCFTbzfzGgOHAaCzTcneY2rbJr6O9Swp+0pjt7lkLv/rAI89eTg452pglvt+bszW1Jgxh4oSIEG2uD8dhECxZSwbuvl0utZAVkol4TWTijtzMRy2tOxE1zn58JMMf55FN2Z3W+ZUibJ5mDECj55nBa2PiTuC+hpCrjCV2JGcUbSePEwQNs+qdFftbydJOv7bw6klB5ei+i7FXkLJ+Nc6zX4faNAdyT0i75pdjSwYVMTSxzuKsvacCOEFu5aup54IFMdm7+5s4s7gQq9YE+rPVPlgGVWZ/tHKm9xqGinru7hTQMPudB3eXC69bDPAceVWTS6smBPHRWXt4NR5bnJiHZ6CAufHawvfQkJxP2miecYOMWNzQFFxnL3N3Dm2kj7LT01bGMtlEycyqI6Mow3hjmxrU07jyoziumiQ1ilTA3u6J7D4AVcqs9tKSBJ8UJ6RNhaSNcO+MDQ/Gkvv7U000fCQpVaCzfwpfl2U1f51Pvdh1VY48gJ1hEjpnzgaX2Xnif+goUHc31Vk3vzXfXpWvZ7qaV/m7P07xbklRtNRpW4sU1H9amxUz38DHt1j7tjZwKAYLVSOHYydaEH
X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1373;
X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1373;20:/x99+0D6TR4EEdwKi4wFrB0G6/Mora7KuNcVYZKIjiKJJryPUh3ez/vIodujE64YF6suEItoJf+VFrKIqmuaPDIPNnrHPNbgq7TsxrYMAePdf1wUSf033eSgXgtr6ZjG3lDy4yBV8GilIxluubW8IvnLKeWDqSLA0BD6FKbWfVY=;4:oX6BXwAF2M7udSKGFFaM+EtWSYN8pVE5qvlrVGbUh2t6leYo0jiG02sGTeaeoVO9atoRx2c5n3m7/ZW5nfDCKCuznk5ovG8NkBUuvfq178J7TkqPbXmvC4tYHehhiGQFye5v8Q2/saI1R6HZs9FDW6INMjW216NY/zwz3Iefa9eV9EYLEYVT9mBshl0H8olhgApNoJuDA89ACkWnT9s93EV84ZeE47mlYXPEImjZgKsGjyY3Bd8U4YmPCzMQtJPAupqtnz0v/CxHFvrYJfvBYTpAByeieMC0dA0ORsfw+RGW6UV3M+ArDzED2IpO7Wc9u70dq1zmuaB3z8QtFVqIWtcRhV+dJCi859tFa4T20DNFEpAZFkrNLpDuGOVg7b0x
X-Microsoft-Antispam-PRVS: <BY1PR0301MB128897B5BC8E0944629F960A9E9E0@BY1PR0301MB1288.namprd03.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:CY1PR03MB1373;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1373;BCL:0;PCL:0;RULEID:(601004)(2401047)(13023025)(13018025)(5005006)(13024025)(13017025)(8121501046)(13015025)(10201501046)(3002001);SRVR:BY1PR0301MB1288;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB1288;
X-Forefront-PRVS: 0903DD1D85
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(4326007)(33716001)(47776003)(189998001)(23726003)(53416004)(42186005)(81166005)(77096005)(93886004)(50986999)(19580405001)(110136002)(2906002)(76176999)(19580395003)(54356999)(5008740100001)(86362001)(1096002)(3846002)(6116002)(586003)(92566002)(5004730100002)(83506001)(4001350100001)(46406003)(66066001)(50466002)(2950100001)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR03MB1373;H:linux-builds1.altera.com;FPR:;SPF:None;MLV:sfv;LANG:en;
X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1373;23:nkLn7mBknR320tLBCKYB3HspkExuqYlwjYAF8T6ukdoeHsLtP4qaqAIyWND/kEQPaPhHwhnbOVHlYVqrpKiRv3XWXkxqbFxq6dfUeg1mPjgC7MjxETayHqiB+ITVA/Nl2R4JD0I6fPK1Gp9xyMxz3MEq8dVV1K+wP23D86yWbQJVMt0QCwsP1LpgdkGS7EhF6IEYVd+8MMDBLmvcvgxOwy1hRHCx2EQjBSJvF6ck/Jkg7vXheVOxV1EmJ9npNR+8cmwfNhgzNroijAhitPFsKH3rai00Pdxd6PtPcXI1UcC0y6DDU3WrAwCgtRJ672LG+C9u83xOdLaim5OHY5cpHwuY2aOFP3zwst4wIfppQE81oXvy1svSpk9FVA0fiStuzyzm9a66v1tfDDeJDWm2DHjLUb977Yw/V44bt2aCcXdc8AbsZDBshCihNlcOn8DseVhAWT1yMep22ALtkhn8tBdwW8hDLcCUup0FUrIWLiw0BRQcRArJcWKTh0k0R7Pe5Z/Xz3QsGnDwVj4oflhVpa79C4fpPEM18NDyvvFEVganSpfQp7DuIlWkFRdodyNPsxUz4Kn5FTox+qFzoevEEOQQKF6EsoDRk1b5Bj9T4g2xjsbQERLHEHDEIm1l9rfIIyqwTHjckrWNFMZJgkJJ7pp4PbGDeR/KpyjqW2KIx/Z5BKlVsmO8W9V+vpMJBG5x9XLj/AtI8LmH4s0bohpoj2g5VCEl20A8oQ/yQ4zprYcUI7DMPPJDL5dxTXhWkNtBOLsHm6MITKnoRWhaBmYz/W4iGulT2IUc49X7wF68BBToL58zvZhH/f6AFF16WCZq9EE0PTadUATNIRaakU3dethyqAuzfOkpYk2iffXJszyaHd2mNpAggDwTIs3f4iwSE26gmIxxeXO9Fx/a1m5ZzCuHPxhLos7rMq0XDmEhrRvjg4343BsUTVJkOdtGaudN
X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1373;5:afvEHKlepjWgOZCxYYNnlfjqtJEdqFDJdWvD6uebhVa0n+iJl25qF2TZUyDmXqn5bxo4J6C1mJufUgNWDjzfleoF9NkQMYwy9zmxn6BmEUlsujRzbkpi36JAzAG1KsWTIRht7SB2z01+fd1UYkqB8g==;24:a7TbWWR59IUuNRYZJHUWE+cOHc7KxtKXVudsuo2i+exoKKN4lnAP6VVueqiFgWb+hc6dYAyWUr6pafutIzPBLwpMbtLygZpQFjNmx73lpvw=;20:GkYyqDbdoIaXYrUoEWhuFOGHvP1H3UfoeNtmuNvIZSDA70xoC07iSHo6nMJd//+QX+0JXwXFJEbCRsfGhwciIosLd7y7geOmea/ap2bonRQIA4Kz0jcny8GE0/MRimbM59CO598WCbD+e2eltrjSvo2zLY9Gv/mlq7MI+sKcatg=
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1373
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1BFFO11FD008.protection.gbl
X-Forefront-Antispam-Report: CIP:66.35.236.236;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(189002)(24454002)(199003)(2906002)(5004730100002)(105606002)(77096005)(85426001)(106466001)(4326007)(50466002)(2950100001)(19580395003)(3720700001)(92566002)(19580405001)(4001350100001)(87936001)(86362001)(83506001)(189998001)(110136002)(23726003)(66066001)(6116002)(3846002)(586003)(5008740100001)(50986999)(46406003)(956001)(1096002)(1220700001)(81166005)(53416004)(6806005)(47776003)(33716001)(16796002)(54356999)(21840400001)(76176999)(93886004)(11100500001)(7099028)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR0301MB1288;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;MLV:sfv;MX:1;A:0;LANG:en;
X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD008;1:za6fx3VdmkY5Hkt5nXRAl4b69HeBkAmKgS8aLBF9hdOpfPkleehvGhHUhu/Y5JyJnZCFhT9zX4lX4N1pOQzU8T8GjnR0WRbLrETdRUre9lGx9vdUnSdm72dJSOdmRFkW7dMy4V5Me05XGnc3dMutm+0DIDTioMSTaSHzZkZawz6nWoCoSWnxNTz68L1WlmpgWskPBxdZGATqS+o2V17Hm/Aclr1jiS19rmDusrNcvaq982J+mTGK/CVWYeIDjCMA/X1OEQ4bLzOPdym9Fx1oC3abHm1WKU66ZboR9bGsC2bpWI2V945Jit5yZpk/yl5IMtwU9Ntdnj3NutY1OrIFU23xhbXme7OOZewqlJXtL59IzYBPm7ySB8xq9pyLLVwwQY85ErGEE79kR/ZbDRvGnADWJGiqqB06ssPJpYHKyS70GVnWpN0XSxCve15Eva+Sjk/nOYHPgxroeImPZvYgZU818NQTzzmQHeaWSrPtsByfyjOlp6WHbREZ8V8mtgKWyMeb510FIeqp8LnnJzq8QG74wiykMNRD7J9d1qtOT74GvyrkPSSRfVrdnIBHKi1z
X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB1288;2:u7arLMYJ9OigMSSluQiMQWvzl0SjqpZpcKTwaE5lWepXh5pKv7ZUy1TTI6dcOsS+5+KcUXe0K7t1s/sh6CQ0mmh6rq9XTEvcQy8VaSa0g3qRlfvM+GoQq4sX3+8FZr+WZYlZ1JzHM3FreCBZ+33Y4JDcxmAdeqwV3dcwMF8MqZuHZOdmHPnFX12cNvMbKErl;3:SSerGOlTJNeOVcnRdzUwsZBtnJwmm6pHMsQ3DpLx7U636gtT4kFiUjezRNssgt9vwcoApG9r38gnTZkHzB0SeAHrSSRviLXjV1tOemis+vRhXyV9z0oI6NE8VzTTLXygX+f6bDoxxvL2caMvEKr+uwu7DrE+UvnzByWzpUhzOhUXDJvCpBBwsBXay3Ul4kneBEQ8ud7rPyXtQryGVDc9TYtzaazxNfiO+McP/eXZKd94mjN8qJ0DDJWSuoy16Mr7;25:ifbAavLXBiXwZhIfATshFyk/Jus0JITfwPSwi1+guiQkVbe7TFHX3urHhvOCQfZarzHGVMAr1SBKI/yV3Ow+l0DoIaJlaDcxfOx/AznQdKverG1+ZMaMWU7wvZxgNCftbwofigt78mok/gNXZkV3rDUPKd6z01ppBlzA/PpA/3+wEgyQsdN/OZE3cCvt9Mqdbhcd1EzbUOjgXedymBN/puqMRLplk7JDWKxbKZ6JbQiunXztPA/R3OXOuQGo3GDXxN95A691pEL7ULfKk31z/p6R2Ih6eKfMtBQcA/lRUMUJEfjQSMmnfF98Iy8jZJKnLsc+wfOtbXb0v6xUECKV8c2NYc3CV2Ue7WCaQUO4YdE=
X-DkimResult-Test: Passed
X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(3001016);SRVR:BY1PR0301MB1288;
X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB1288;20:UnSCs3wk+VM6/QFV8wwXYfRDyyRfYhY92314UEOTNCXZ0LO2yJf1M+CpTA1WfS+iWzxlYZ4z6/Zur+a8oWghC8uv5PRczomjpm7HBM6dc7UE6qSzgVlZV00fL9mqct7h2l7+RUTacXDmbFjkXnE+xVGKikUyZn9T3fNPj+++/Ro=;4:4PTZOzaC3xM+qXcVoQlAVz2mEgSVnmvdvcIzraj+dBFPrupFZ4ihXKUNPeID0PM+FqYe7Mz2EsVMoX78KnSgPKOezJYLlBukkTh3x8y69CJH3my6CXkkwmyQSaHNGGR0An6CuamT/vIt/gCf6cyXZwR99EvL8JhPwSdJEeO7KEazncgmX7gHIwrE0WLY5Ew0BGg0IcEVVkgfoCUvO3DNLMe3XbajbZ/5v0s6pZXRTyzxDKcunOAiswE5Thfd2zIYyj+vNkb/UMi2aEyshSFUdjnXjTM+7MxIyBJm/A+xJmURP7Gfv2pSZsYxFq/LKIfdLoIIoIxKLMBoxT6AESQXP4W0DeeWXLB7nmXDX/6BqxpP4D7iRU3VdsYSta3Opq/JCwclIh4Vx+uSQ7SsIEh1ym3pUtHE8NDm4pUdYT8frERC0AiH+mY84Z8UpCfa2LCBp/PTmEdbZqQhIl8mXiG4qQ==
X-Forefront-PRVS: 0903DD1D85
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY1PR0301MB1288;23:5zQ+8CRRAxXnxsTz7KpnISMSD9b2/4kErYDcg+3?=
 =?us-ascii?Q?XyNKchbIzIcRmbODE0uMazo24/VzDuK9xnq49oA4MaIy0/Ot1rSlLileWfEi?=
 =?us-ascii?Q?fVa8MH5lzAZ15ecFzBjN1Ihv3OzXtamCcIGIvtkKnY0kSzsfmMcbbu5a8Tjg?=
 =?us-ascii?Q?neiu7mMOooZ9Riodx5stEcFEEw6jeDSWvR8oPfc8DlDcDf8nXzdLsdd3gfVq?=
 =?us-ascii?Q?/XSvuqVHvvwUi+NeJ0lWia2KpK78nbjHDeFrs+9sZEq1PytTWrLNV5dFA6O+?=
 =?us-ascii?Q?26nk4h+YBOBPSGemE6IF8S73ZkkdTvPmf9xSDDytATXsrmwWEGJc8Cl4zz3u?=
 =?us-ascii?Q?5e5ZJy3H9J+ZMZqo+YqqdBZAFI2KZT7JAJdzdxFJW7HIGtm9Qj/dQfhk01nW?=
 =?us-ascii?Q?RX1gYrK3dXUtYLOyx9/clO8D28X7SMMbju3NAWV09uMO/Y5AODZ1MV0/TykO?=
 =?us-ascii?Q?+W1KJXqKdT68IEr3YOt7OHGPjAn9qvrQDIM5vz24NMOdfaiNukcw9EEztINY?=
 =?us-ascii?Q?xKQsWy4gz7nwwhpuqjjyFqfyeb7IDnLTtho4K1dBJivdAAU2RU+lBgqeD3O6?=
 =?us-ascii?Q?Q941cLmFAJywyKNREPXhgmZ34f/TS4X+w6DpK6S0OiZSRtlFr1onOH94zidd?=
 =?us-ascii?Q?QlHuTegSBweXbjdq2h+gS46+NsZlDVuxukCLrt20Oq4dhT67OwGvicwFaC1f?=
 =?us-ascii?Q?fksrIOKTpccCEUsQcIa2MSgqvoKv+p5X7tRGAk8BUfOFOM2e0aR1MM6w8aKc?=
 =?us-ascii?Q?JhkhD1P2C5d7uR0Xen2u+el8hob+o+j1BaCq7npp0Q3bmJsJ+akGcR+3w7Ee?=
 =?us-ascii?Q?dmJzhVLqJL4Mku+ZPTPdtG9RYIx8AkA3Q9fdRtNePeXrhIduysteHYhs3tf/?=
 =?us-ascii?Q?mKKqCNzS+wQpc3bGML2MpX+odFJ+Oo+Vfsm7px/0bGhV2g4LsrUCrpH12tAe?=
 =?us-ascii?Q?dqiK96Fx1+NqXLiYWZt4KA1Q1rSat0bVvjozj8J5HlP2HxnUPVWZbPGRsWAU?=
 =?us-ascii?Q?3r85KAJ+C7bEgZ5TguGu5apzG5cZ1zHFRSYVW2jF2MWz+MW3mj5IPBPo5JWn?=
 =?us-ascii?Q?DePwOooaqCerS02scSTFn0v/WXUzSHjxzRgxYAsSrCDnPMiRSOerOxRXbn2M?=
 =?us-ascii?Q?xG4K9EzIi/1kBcYy4NBrcZRXepyUsKr7v7FlhTVcVsC9YAdUSzCUAEShR9aA?=
 =?us-ascii?Q?n68NWeK/w3/eE4pEKy9uG70x9iax7vuzpfw8V/aglp4LNQl072VE8oHTw7+K?=
 =?us-ascii?Q?UlEKZVcpbENuFaZdxItGthzNFiy9MN5cHlMI3+rydLsdVlHtw2N9V69RSRvB?=
 =?us-ascii?Q?7nQ=3D=3D?=
X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB1288;5:OstVOpbrFim3DGFXtuKB2z6xuVr+qvq+tvmOsn6odE83T65bKn651Qq8oE9BrXDxnEg9dHrjcBQsL4uy6E7Kf/LJ75XUdv7naLgIsxUCUuD9f9xf6wSSl4Zotd097qG9Ucs1ollbDa1LeRp05yJwxA==;24:k3UdANuIT3ntk5wMM65g4EpPYUgghHy3VSQYBPOHAAi3P76MIoRkgH2yAOZZWaYsw3BkO5SqVrB8I6a4hUwYWMpfT+F+rSZOB5JJlpMPJls=;20:Bwb/uP6Cwyi/UDymAuicHed0FSkFyvqR5f9jPrq1eDmroNHrSWgjv/ZkbT/2SiB6OAgCelSDuzBxG/3nLOv0/QwKbZDwpMAQxybEUX3wl758z3bpEB4URece5hdu/AeXWkfVBwaUSY8cVDG4gH6B/2KrVEmw9ocJjelYop7lv7M=
X-OriginatorOrg: opensource.altera.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2016 18:44:56.3903
 (UTC)
X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0301MB1288
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 633
Lines: 23

On Tue, 5 Apr 2016, Borislav Petkov wrote:

> On Tue, Apr 05, 2016 at 12:25:33AM -0500, Thor Thayer wrote:
> > I realize that I'm not calling iounmap(ecc_block_base) and I'll fix that in
> > the next revision with a goto.
> 
> I'm assuming nothing else changes. Because I've applied 1-4 already.
> 
> Yes, no?
> 
> If no, then please send only an updated version of this patch as a reply
> to this thread here.
> 

My only suggestion was to change the 3 helper functions(ecc_set_bits,
ecc_clear_bits, and ecc_test_bits) should be static inline.

So with that change:

Acked-by: Dinh Nguyen <dinguyen@opensource.altera.com>

BR,
Dinh