Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751907AbcDETGV (ORCPT ); Tue, 5 Apr 2016 15:06:21 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:58478 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751916AbcDETGS (ORCPT ); Tue, 5 Apr 2016 15:06:18 -0400 From: Dave Gerlach To: , CC: Daniel Lezcano , "Rafael J . Wysocki" , Dave Gerlach Subject: [PATCH] cpuidle: Indicate when a device has been unregistered Date: Tue, 5 Apr 2016 14:05:38 -0500 Message-ID: <1459883138-21136-1-git-send-email-d-gerlach@ti.com> X-Mailer: git-send-email 2.7.3 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1175 Lines: 31 Currently the 'registered' member of the cpuidle_device struct is set to 1 during cpuidle_register_device. In this same function there are checks to see if the device is already registered to prevent duplicate calls to register the device, but this value is never set to 0 even on unregister of the device. Because of this, any attempt to call cpuidle_register_device after a call to cpuidle_unregister_device will fail which shouldn't be the case. To prevent this, set registered to 0 when the device is unregistered. Fixes: c878a52d3c7c ("cpuidle: Check if device is already registered") Signed-off-by: Dave Gerlach --- drivers/cpuidle/cpuidle.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c index f996efc56605..c2dd99ab1648 100644 --- a/drivers/cpuidle/cpuidle.c +++ b/drivers/cpuidle/cpuidle.c @@ -433,6 +433,8 @@ static void __cpuidle_unregister_device(struct cpuidle_device *dev) list_del(&dev->device_list); per_cpu(cpuidle_devices, dev->cpu) = NULL; module_put(drv->owner); + + dev->registered = 0; } static void __cpuidle_device_init(struct cpuidle_device *dev) -- 2.7.3