Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933523AbcDETcN (ORCPT ); Tue, 5 Apr 2016 15:32:13 -0400 Received: from www62.your-server.de ([213.133.104.62]:35201 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933351AbcDETcL (ORCPT ); Tue, 5 Apr 2016 15:32:11 -0400 Message-ID: <570412B0.9000203@iogearbox.net> Date: Tue, 05 Apr 2016 21:32:00 +0200 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Naveen N. Rao" , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org CC: Alexei Starovoitov , "David S. Miller" , Ananth N Mavinakayanahalli , Michael Ellerman , Paul Mackerras , Michael Holzheu Subject: Re: [PATCH net 1/4] lib/test_bpf: Fix JMP_JSET tests References: <5e3cf7c4a971e6d2ff7a2d50bbec2e6e26883b84.1459850410.git.naveen.n.rao@linux.vnet.ibm.com> In-Reply-To: <5e3cf7c4a971e6d2ff7a2d50bbec2e6e26883b84.1459850410.git.naveen.n.rao@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1990 Lines: 58 On 04/05/2016 12:02 PM, Naveen N. Rao wrote: > JMP_JSET tests incorrectly used BPF_JNE. Fix the same. > > Cc: Alexei Starovoitov > Cc: Daniel Borkmann > Cc: "David S. Miller" > Cc: Ananth N Mavinakayanahalli > Cc: Michael Ellerman > Cc: Paul Mackerras > Signed-off-by: Naveen N. Rao Acked-by: Daniel Borkmann > --- > lib/test_bpf.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/test_bpf.c b/lib/test_bpf.c > index 27a7a26..e76fa4d 100644 > --- a/lib/test_bpf.c > +++ b/lib/test_bpf.c > @@ -4303,7 +4303,7 @@ static struct bpf_test tests[] = { > .u.insns_int = { > BPF_ALU32_IMM(BPF_MOV, R0, 0), > BPF_LD_IMM64(R1, 3), > - BPF_JMP_IMM(BPF_JNE, R1, 2, 1), > + BPF_JMP_IMM(BPF_JSET, R1, 2, 1), > BPF_EXIT_INSN(), > BPF_ALU32_IMM(BPF_MOV, R0, 1), > BPF_EXIT_INSN(), > @@ -4317,7 +4317,7 @@ static struct bpf_test tests[] = { > .u.insns_int = { > BPF_ALU32_IMM(BPF_MOV, R0, 0), > BPF_LD_IMM64(R1, 3), > - BPF_JMP_IMM(BPF_JNE, R1, 0xffffffff, 1), > + BPF_JMP_IMM(BPF_JSET, R1, 0xffffffff, 1), > BPF_EXIT_INSN(), > BPF_ALU32_IMM(BPF_MOV, R0, 1), > BPF_EXIT_INSN(), > @@ -4474,7 +4474,7 @@ static struct bpf_test tests[] = { > BPF_ALU32_IMM(BPF_MOV, R0, 0), > BPF_LD_IMM64(R1, 3), > BPF_LD_IMM64(R2, 2), > - BPF_JMP_REG(BPF_JNE, R1, R2, 1), > + BPF_JMP_REG(BPF_JSET, R1, R2, 1), > BPF_EXIT_INSN(), > BPF_ALU32_IMM(BPF_MOV, R0, 1), > BPF_EXIT_INSN(), > @@ -4489,7 +4489,7 @@ static struct bpf_test tests[] = { > BPF_ALU32_IMM(BPF_MOV, R0, 0), > BPF_LD_IMM64(R1, 3), > BPF_LD_IMM64(R2, 0xffffffff), > - BPF_JMP_REG(BPF_JNE, R1, R2, 1), > + BPF_JMP_REG(BPF_JSET, R1, R2, 1), > BPF_EXIT_INSN(), > BPF_ALU32_IMM(BPF_MOV, R0, 1), > BPF_EXIT_INSN(), >