Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933739AbcDEU3d (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 Apr 2016 16:29:33 -0400
Received: from mail-bl2on0148.outbound.protection.outlook.com ([65.55.169.148]:37077
	"EHLO na01-bl2-obe.outbound.protection.outlook.com"
	rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
	id S933626AbcDEU3b convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 Apr 2016 16:29:31 -0400
X-Greylist: delayed 943 seconds by postgrey-1.27 at vger.kernel.org; Tue, 05 Apr 2016 16:29:30 EDT
From: Jake Oshins <jakeo@microsoft.com>
To: Bjorn Helgaas <helgaas@kernel.org>
CC: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        KY Srinivasan <kys@microsoft.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "olaf@aepfle.de" <olaf@aepfle.de>,
        "apw@canonical.com" <apw@canonical.com>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Hadden Hoppert <haddenh@microsoft.com>
Subject: RE: [PATCH v4 3/7] drivers:hv: Use new vmbus_mmio_free() from client
 drivers.
Thread-Topic: [PATCH v4 3/7] drivers:hv: Use new vmbus_mmio_free() from client
 drivers.
Thread-Index: AQHRjGuw8LmEfTb7zkWSNv/gSwPgyp97sQyAgAAlNKA=
Date: Tue, 5 Apr 2016 20:13:28 +0000
Message-ID: <DM2PR0301MB1232E1739F8668D40B1F0F13AB9E0@DM2PR0301MB1232.namprd03.prod.outlook.com>
References: <y> <1459558067-1725-1-git-send-email-jakeo@microsoft.com>
 <1459558067-1725-4-git-send-email-jakeo@microsoft.com>
 <20160405175949.GA15353@localhost>
In-Reply-To: <20160405175949.GA15353@localhost>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=microsoft.com;
x-originating-ip: [2001:4898:80e8:8::563]
x-ms-office365-filtering-correlation-id: baa44dc7-56a5-4058-93b0-08d35d8ec0ca
x-microsoft-exchange-diagnostics: 1;DM2PR0301MB0783;5:IAUkPgS82VGDcipVnxMIyYvkGmSAbBO2GMdi3FWP2XjamTh8kaeeMhVE2THVjnJM24gAAvKJUOjGSumh+h8ptLs6aQ8ewO/BZkqVZ/UKTGGroIp9XFQZDYHks66mZKkJCsRdAmHztP14J2SiSHDqDw==;24:v/zWD9s+yM9isihWBfGZ1L8VbKNNA3eS/y85F9siBfgttteWcPzTofGr2pazcnLp08BxMgKQ2f0crppCRlXTHGiF6jvPtOnihykiAhP10Sk=
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0783;
x-microsoft-antispam-prvs: <DM2PR0301MB0783E3D533AE0682CC45035BAB9E0@DM2PR0301MB0783.namprd03.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:;
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(61426038)(61427038);SRVR:DM2PR0301MB0783;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0783;
x-forefront-prvs: 0903DD1D85
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(13464003)(377454003)(8990500004)(10400500002)(5005710100001)(10290500002)(99286002)(107886002)(87936001)(110136002)(106116001)(189998001)(10090500001)(122556002)(76176999)(54356999)(50986999)(81166005)(86612001)(586003)(102836003)(6116002)(77096005)(5002640100001)(4001430100002)(76576001)(1096002)(1220700001)(2906002)(5008740100001)(4326007)(86362001)(5004730100002)(11100500001)(2950100001)(2900100001)(19580395003)(3280700002)(19580405001)(74316001)(33656002)(3660700001)(5003600100002)(92566002)(3826002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR0301MB0783;H:DM2PR0301MB1232.namprd03.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2016 20:13:28.8893
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0783
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1463
Lines: 36

> -----Original Message-----
> From: Bjorn Helgaas [mailto:helgaas@kernel.org]
> Sent: Tuesday, April 5, 2016 11:00 AM
> To: Jake Oshins <jakeo@microsoft.com>
> Cc: linux-pci@vger.kernel.org; gregkh@linuxfoundation.org; KY Srinivasan
> <kys@microsoft.com>; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> vkuznets@redhat.com; Haiyang Zhang <haiyangz@microsoft.com>; Hadden
> Hoppert <haddenh@microsoft.com>
> Subject: Re: [PATCH v4 3/7] drivers:hv: Use new vmbus_mmio_free() from
> client drivers.
> 
> Hi Jake,
> 
> On Fri, Apr 01, 2016 at 05:47:43PM -0700, Jake Oshins wrote:
> > This patch modifies all the callers of vmbus_mmio_allocate()
> > to call vmbus_mmio_free() instead of release_mem_region().
> 
> This changelog merely restates the C code.  Presumably there's some
> important difference between release_mem_region() and
> vmbus_mmio_free(), and we need a hint about what that is.
> 
> Oh, I see, there actually is no difference *yet*, but it's coming.
> I'd combine this with patch 2.  Then the patch is obviously correct
> all by itself, and the changelog for patch 2 makes clear what's
> happening.
> 
> In changelogs, don't bother with "this patch does" or "this function
> is introduced."  The context is obvious because the changelog is part
> of the commit.  Write imperative sentences, e.g., "Call
> vmbus_mmio_free() instead of release_mem_region()."
> 

Will do.  Thanks.

-- Jake Oshins