Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760119AbcDEVRM (ORCPT ); Tue, 5 Apr 2016 17:17:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49847 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753847AbcDEVRK (ORCPT ); Tue, 5 Apr 2016 17:17:10 -0400 Date: Tue, 5 Apr 2016 16:17:06 -0500 From: Josh Poimboeuf To: Minfei Huang Cc: Jiri Kosina , Jessica Yu , Miroslav Benes , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Vojtech Pavlik Subject: Re: [RFC PATCH v1.9 12/14] livepatch: create per-task consistency model Message-ID: <20160405211706.t3ay6e42mzujpdzo@treble.redhat.com> References: <74a2b37cea7a64a185e50876dba031137aa59a24.1458933243.git.jpoimboe@redhat.com> <20160405173248.GA2450@huangminfeis-MacBook-Pro.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160405173248.GA2450@huangminfeis-MacBook-Pro.local> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 779 Lines: 24 On Wed, Apr 06, 2016 at 01:32:48AM +0800, Minfei Huang wrote: > On 03/25/16 at 02:34P, Josh Poimboeuf wrote: > > +static int klp_check_stack(struct task_struct *task) > > +{ > > + static unsigned long entries[MAX_STACK_ENTRIES]; > > + struct stack_trace trace; > > + struct klp_object *obj; > > + struct klp_func *func; > > + int ret; > > + > > + trace.skip = 0; > > + trace.nr_entries = 0; > > + trace.max_entries = MAX_STACK_ENTRIES; > > + trace.entries = entries; > > + ret = save_stack_trace_tsk_reliable(task, &trace); > > Format the array entries before using it. Do you mean zero the array? If so, that's not necessary because save_stack_trace_tsk_reliable() doesn't require it. But regardless it will automatically be zeroed because it's a static variable. -- Josh