Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760581AbcDEVyJ (ORCPT ); Tue, 5 Apr 2016 17:54:09 -0400 Received: from www62.your-server.de ([213.133.104.62]:51282 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760532AbcDEVyH (ORCPT ); Tue, 5 Apr 2016 17:54:07 -0400 Message-ID: <570433F0.6040506@iogearbox.net> Date: Tue, 05 Apr 2016 23:53:52 +0200 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Bastien Philbert , vyasevich@gmail.com CC: nhorman@tuxdriver.com, davem@davemloft.net, linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sctp: Fix error handling for switch statement case in the function sctp_cmd_interprete References: <1459892201-21397-1-git-send-email-bastienphilbert@gmail.com> In-Reply-To: <1459892201-21397-1-git-send-email-bastienphilbert@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1258 Lines: 34 On 04/05/2016 11:36 PM, Bastien Philbert wrote: > This fixes error handling for the switch statement case > SCTP_CMD_SEND_PKT by making the error value of the call > to sctp_packet_transmit equal the variable error due to > this function being able to fail with a error code. In What actual issue have you observed that you fix? > addition allow the call to sctp_ootb_pkt_free afterwards > to free up the no longer in use sctp packet even if the > call to the function sctp_packet_transmit fails in order > to avoid a memory leak here for not freeing the sctp Not sure how this relates to your code? > Signed-off-by: Bastien Philbert > --- > net/sctp/sm_sideeffect.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c > index 7fe56d0..f3a8b58 100644 > --- a/net/sctp/sm_sideeffect.c > +++ b/net/sctp/sm_sideeffect.c > @@ -1434,7 +1434,7 @@ static int sctp_cmd_interpreter(sctp_event_t event_type, > case SCTP_CMD_SEND_PKT: > /* Send a full packet to our peer. */ > packet = cmd->obj.packet; > - sctp_packet_transmit(packet, gfp); > + error = sctp_packet_transmit(packet, gfp); > sctp_ootb_pkt_free(packet); > break; > >