Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760218AbcDEXjs (ORCPT ); Tue, 5 Apr 2016 19:39:48 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:48748 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943AbcDEXjr (ORCPT ); Tue, 5 Apr 2016 19:39:47 -0400 Date: Wed, 6 Apr 2016 01:39:43 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next] net: dsa: document missing functions Message-ID: <20160405233943.GA19409@lunn.ch> References: <1459869760-23295-1-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459869760-23295-1-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1879 Lines: 52 On Tue, Apr 05, 2016 at 11:22:40AM -0400, Vivien Didelot wrote: > Add description for the missing port_vlan_prepare, port_fdb_prepare, > port_fdb_dump functions in the DSA documentation. > > Signed-off-by: Vivien Didelot Hi Vivien A few English improvements: > --- > Documentation/networking/dsa/dsa.txt | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/networking/dsa/dsa.txt b/Documentation/networking/dsa/dsa.txt > index 3b196c3..8ba3369 100644 > --- a/Documentation/networking/dsa/dsa.txt > +++ b/Documentation/networking/dsa/dsa.txt > @@ -542,6 +542,12 @@ Bridge layer > Bridge VLAN filtering > --------------------- > > +- port_vlan_prepare: bridge layer function invoked when the bridge prepares the > + configuration of a VLAN on the given port. If the operation is not > + programmable, this function should return -EOPNOTSUPP to inform the bridge s/programmable/supported by the hardware > + code to fallback to a software implementation. No hardware programmation s/programmation/setup > + must be done in this function. See port_vlan_add for this and details. > + > - port_vlan_add: bridge layer function invoked when a VLAN is configured > (tagged or untagged) for the given switch port > > @@ -552,6 +558,12 @@ Bridge VLAN filtering > function that the driver has to call for each VLAN the given port is a member > of. A switchdev object is used to carry the VID and bridge flags. > > +- port_fdb_prepare: bridge layer function invoked when the bridge prepares the > + installation of a Forwarding Database entry. If the operation is not > + programmable, this function should return -EOPNOTSUPP to inform the bridge s/programmable/supported > + code to fallback to a software implementation. No hardware programmation s/programmation/setup Andrew