Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760752AbcDEXl5 (ORCPT ); Tue, 5 Apr 2016 19:41:57 -0400 Received: from mga01.intel.com ([192.55.52.88]:6628 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760253AbcDEXly (ORCPT ); Tue, 5 Apr 2016 19:41:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,445,1455004800"; d="scan'208";a="681411760" Date: Tue, 5 Apr 2016 16:41:47 -0700 From: Vinod Koul To: Stanimir Varbanov Cc: Rob Herring , Mark Rutland , Andy Gross , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Sinan Kaya , Pramod Gurav Subject: Re: [PATCH v2 2/5] dmaengine: qcom: bam_dma: clear BAM interrupt only if it is rised Message-ID: <20160405234141.GC11586@vkoul-mobl.iind.intel.com> References: <1459896982-30171-1-git-send-email-stanimir.varbanov@linaro.org> <1459896982-30171-3-git-send-email-stanimir.varbanov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459896982-30171-3-git-send-email-stanimir.varbanov@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 387 Lines: 12 On Wed, Apr 06, 2016 at 01:56:19AM +0300, Stanimir Varbanov wrote: s/rised/raised ? > Currently we write BAM_IRQ_CLR register with zero even when no > BAM_IRQ occured. This write has some bad side effects when the > BAM instance is for the crypto engine. In case of crypto engine > some of the BAM registers are xPU protected and they cannot be > controlled by the driver. -- ~Vinod